Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing HLint execution on runners due to missing libtinfo5 dependency #3399

Closed
wants to merge 2 commits into from
Closed

Fixing HLint execution on runners due to missing libtinfo5 dependency #3399

wants to merge 2 commits into from

Conversation

F-WRunTime
Copy link
Member

@F-WRunTime F-WRunTime commented Dec 7, 2022 •
edited
Loading

No description provided.

@F-WRunTime F-WRunTime changed the title Test pushing, confirming failure of Hlint on master Fixing HLint execution on runners due to missing libtinfo5 dependency Dec 7, 2022
@F-WRunTime
Copy link
Member Author

Per issues found in this PR by @treeowl
#3396

Installation on public runner of library enables execution of Hlint

@F-WRunTime F-WRunTime self-assigned this Dec 7, 2022
@F-WRunTime F-WRunTime marked this pull request as ready for review December 7, 2022 20:24
@treeowl
Copy link
Contributor

treeowl commented Dec 7, 2022

It's hard to know what to think of this unless/until integration tests can run. HLint was only the least important symptom.

Baltoli
Baltoli approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me if the CI passes!

treeowl
treeowl approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@treeowl treeowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I also approve if CI passes.

@treeowl
Copy link
Contributor

treeowl commented Dec 7, 2022

Question: should we just stop requiring M1 (apparently experimental, and currently down) and macos12 (generally sluggish) tests to run before triggering the integration and perf tests?

@treeowl
Copy link
Contributor

treeowl commented Dec 8, 2022

Unfortunately, it seems there's more left to fix here. 😕

@goodlyrottenapple
Copy link
Contributor

closing in favour of #3401, since the underlying issue with the cachix action on ubuntu-22.04 cachix/cachix-action#130 is currently unsolved.

@F-WRunTime
Copy link
Member Author

F-WRunTime commented Dec 8, 2022 •
edited
Loading

closing in favour of #3401, since the underlying issue with the cachix action on ubuntu-22.04 cachix/cachix-action#130 is currently unsolved.

@goodlyrottenapple
The mentioned above lacks the other additional changes as it was to also update and sync the checkout versions and install a supporting package for Hlint. @treeowl and I proved that got us through the failing Hlint tests.
I'm not sure this PR should be thrown out just yet..

@F-WRunTime F-WRunTime reopened this Dec 8, 2022
@F-WRunTime F-WRunTime marked this pull request as draft December 8, 2022 15:58
@F-WRunTime F-WRunTime closed this Dec 8, 2022
@F-WRunTime F-WRunTime deleted the feature/version-pkg-updates branch December 8, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeowl treeowl treeowl approved these changes

@Baltoli Baltoli Baltoli approved these changes

@ana-pantilie ana-pantilie Awaiting requested review from ana-pantilie

Assignees

@F-WRunTime F-WRunTime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@F-WRunTime @treeowl @goodlyrottenapple @Baltoli