Merge pull request #219 from runceel/main

v7.6.0

.github/workflows/build-and-publish.yml

@@ -16,9 +16,9 @@ jobs:
     - name: Setup .NET Core
       uses: actions/setup-dotnet@v1
       with:
-        dotnet-version: 3.1.402
-    - name: Setup MSBuild.exe
-      uses: warrenbuckley/Setup-MSBuild@v1
+        dotnet-version: 3.1.*
+    - name: Add msbuild to PATH
+      uses: microsoft/setup-msbuild@v1.0.2
     - name: Update version number
       if: github.ref != 'refs/heads/release'
       shell: pwsh

.github/workflows/deploy-document.yml

@@ -25,7 +25,7 @@ jobs:
         npm run docs:build
       working-directory: docs
     - name: Deploy 🚀
-      uses: JamesIves/github-pages-deploy-action@3.6.1
+      uses: JamesIves/github-pages-deploy-action@3.7.1
       with:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         BRANCH: gh-pages # The branch the action should deploy to.

.github/workflows/dotnet-core-unit-testing.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Setup .NET Core
       uses: actions/setup-dotnet@v1
       with:
-        dotnet-version: 3.1.402
+        dotnet-version: 3.1.*
     - name: Install dependencies
       run: dotnet restore ReactiveProperty.sln
     - name: Test

Source/ReactiveProperty.NETStandard/AsyncReactiveCommand.cs

@@ -46,10 +46,12 @@ public AsyncReactiveCommand(IReactiveProperty<bool> sharedCanExecute)
         /// <summary>
         /// Push null to subscribers.
         /// </summary>
-        public void Execute()
-        {
-            Execute(null);
-        }
+        public void Execute() => Execute(null);
+
+        /// <summary>
+        /// Push null to subscribers.
+        /// </summary>
+        public Task ExecuteAsync() => ExecuteAsync(null);
 
         /// <summary>
         /// Subscribe execute.
@@ -146,7 +148,12 @@ bool ICommand.CanExecute(object parameter)
         /// <summary>
         /// Push parameter to subscribers, when executing CanExecuting is changed to false.
         /// </summary>
-        public async void Execute(T parameter)
+        public async void Execute(T parameter) => await ExecuteAsync(parameter);
+
+        /// <summary>
+        /// Push parameter to subscribers, when executing CanExecuting is changed to false.
+        /// </summary>
+        public async Task ExecuteAsync(T parameter)
         {
             if (isCanExecute)
             {

Source/SharedProperties.csproj

@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <RootNamespace>Reactive.Bindings</RootNamespace>
-    <Version>7.5.1</Version>
+    <Version>7.6.0</Version>
     <Authors>neuecc xin9le okazuki</Authors>
     <PackageProjectUrl>https://github.com/runceel/ReactiveProperty</PackageProjectUrl>
     <PackageTags>rx mvvm async rx-main reactive</PackageTags>
@@ -15,6 +15,7 @@
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
   <ItemGroup>
     <None Include="../../Assets/ReactivePropertyIcon_100x100.png" LinkBase="Assets" Pack="true" PackagePath="/" />

Test/ReactiveProperty.NETStandard.Tests/AsyncReactiveCommandTest.cs

@@ -10,6 +10,42 @@ namespace ReactiveProperty.Tests
     [TestClass]
     public class AsyncReactiveCommandTest
     {
+        [TestMethod]
+        public void ExecuteAsync()
+        {
+            var tcs = new TaskCompletionSource<bool>();
+            var cmd = new AsyncReactiveCommand().WithSubscribe(async () =>
+            {
+                await tcs.Task;
+            });
+
+            Task taskForExecuteAsync = cmd.ExecuteAsync();
+
+            taskForExecuteAsync.IsCompleted.IsFalse();
+            tcs.SetResult(true);
+            taskForExecuteAsync.IsCompleted.IsTrue();
+        }
+
+        [TestMethod]
+        public void ExecuteAsyncForGeneric()
+        {
+            var tcs = new TaskCompletionSource<bool>();
+            var expectedCommandParameter = new object();
+            var actualCommandParameter = default(object);
+            var cmd = new AsyncReactiveCommand<object>().WithSubscribe(async x =>
+            {
+                actualCommandParameter = x;
+                await tcs.Task;
+            });
+
+            Task taskForExecuteAsync = cmd.ExecuteAsync(expectedCommandParameter);
+
+            taskForExecuteAsync.IsCompleted.IsFalse();
+            tcs.SetResult(true);
+            taskForExecuteAsync.IsCompleted.IsTrue();
+            actualCommandParameter.IsSameReferenceAs(expectedCommandParameter);
+        }
+
         [TestMethod]
         public void DefaultUseCase()
         {

docs/docs/.vuepress/config.js

@@ -13,6 +13,7 @@ module.exports = {
                     { text: 'Universal Windows Platform', link: '/getting-started/uwp.html' },
                     { text: 'Xamarin.Forms', link: '/getting-started/xf.html' },
                     { text: 'Avalonia', link: '/getting-started/avalonia.html' },
+                    { text: 'Uno Platform', link: '/getting-started/uno-platform.html' },
                     { text: 'Add code snippets', link: '/getting-started/add-snippets.html' },
                 ]
             },
@@ -46,4 +47,4 @@ module.exports = {
         editLinks: true,
         editLinkText: 'Help us improve this document!',
     }
-}
+}

docs/docs/README.md

@@ -105,6 +105,7 @@ You can start using ReactiveProperty from the following links.
 - [Windows Presentation Foundation](getting-started/wpf.md)
 - [Universal Windows Platform](getting-started/uwp.md)
 - [Xamarin.Forms](getting-started/xf.md)
+- [Uno Platform](getting-started/uno-platform.md)
 
 And learn the core features on following links.
 

docs/docs/features/Notifiers.md

@@ -29,7 +29,17 @@ n.Value = true; // true
 n.Value = false; // false
 ```
 
-It can use to source of `ReactiveCommand`.
+It can use as source of `ReactiveCommand` like below:
+
+```csharp
+var n = new BooleanNotifier(); // the default value is false.
+
+// CanExecute method of ReactiveCommand returns true as default. So, you set initialValue explicitly to `n.Value`.
+var command = n.ToReactiveCommand(initialValue: n.Value);
+
+// Or if you would like to convert to something using Select and others before calling ToReactiveCommand, you can use StartWith.
+var command2 = n.StartWith(n.Value).Select(x => Something(x)).ToReactiveCommand();
+```
 
 ## `CountNotifier`
 

docs/docs/features/Work-together-with-plane-model-layer-objects.md

@@ -245,7 +245,7 @@ namespace ReactivePropertyEduApp
 
 ### Nested property path
 
-`ObserveProperty`, `ToReactivePropertyAsSynchronized` and `ToReactivePropertySlimAsSynchronized` support to nested property path like `x => x.Child.Name`.
+`ObserveProperty`, `ToReactivePropertyAsSynchronized`, `ToReactivePropertySlimAsSynchronized` and `FromObject` support to nested property path like `x => x.Child.Name`.
 Suppose the value of any property in the path is null. In that case, ReactiveProperty is set `default(T)` to Value property (this is a case of to ReactiveProperty from source property), and ReactiveProperty stops synchronization to the source property (this is a case of to source property from ReactiveProperty).
 
-After the value is updated to not null value, ReactiveProperty re-start synchronization.
+After the value is updated to not null value, ReactiveProperty re-start synchronization.

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "3.1.402"
+    "version": "3.1.*"
   },
   "msbuild-sdks": {
     "MSBuild.Sdk.Extras": "2.0.54"