Showcase #1
Closed
Showcase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneskm
reviewed
Jun 24, 2024
abci/src/server.rs
Outdated
|
|
||
| let _ = thread::spawn( move || { | ||
| loop { | ||
| let (stream, addr) = self.listener.accept().map_err(Error::io).expect( "failed to accept connection"); |
There was a problem hiding this comment.
Why do we expect now instead of returning the error?
There was a problem hiding this comment.
'Cause of this line of code. It blocks the main thread and I chose to move it into a separate thread.
What do you think:
- Call expect on error
- Send error with mpsc
- Ignore error and log it
- Don't panic but request cancellation
There was a problem hiding this comment.
Personally I think. Approach with logging error and stopping application better
abci/src/server.rs
Outdated
|
|
||
| }); | ||
|
|
||
| while !CancellationSource::is_cancelled() { } |
There was a problem hiding this comment.
Isn't this going to consume the CPU?
There was a problem hiding this comment.
Yes. I need to add thread::sleep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.