[python] Generate .pyi stubs by default for .proto #352
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a plugin that will generate pyi_out for standard proto. Support for generating pyi stubs with grpc is limited as neither tool currently supports it (I think)
sjportalatin
changed the title
sjportalatin
changed the title
planeyang
reviewed
Oct 26, 2024
|
Thanks, I'll merge this, fix the diff error and will also make this opt-in rather than on by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a plugin that will generate pyi_out for standard proto. As per this comment.
This creates pyi files by default. Might mess with existing implementations, so maybe I can change to a flag or something instead?