Fix grpclib_compile not working with paths with dashes #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing
|python
conversion for grpclib.Modified the default
thing
example to demonstrate the failure in 8685ee8 . However, I do see that a bunch of tests depend on the examples.proto path so I reverted it in my PR.Would like some opinions on whether I should make eamples.proto path contain a dash or leave the test change out of this PR. I'm concerned that this regression would occur again in the future.
I verified in https://github.com/vmagamedov/grpclib/blob/5916cba69fc1f8a25fe8e749e3c4427897b3d228/grpclib/plugin/main.py#L174 and https://github.com/vmagamedov/grpclib/blob/5916cba69fc1f8a25fe8e749e3c4427897b3d228/grpclib/plugin/main.py#L251 that
|python
is appropriate.Fixes #321