Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grpclib_compile not working with paths with dashes #320

Merged

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Jun 26, 2024

There was a missing |python conversion for grpclib.
Modified the default thing example to demonstrate the failure in 8685ee8 . However, I do see that a bunch of tests depend on the examples.proto path so I reverted it in my PR.
Would like some opinions on whether I should make eamples.proto path contain a dash or leave the test change out of this PR. I'm concerned that this regression would occur again in the future.

I verified in https://github.com/vmagamedov/grpclib/blob/5916cba69fc1f8a25fe8e749e3c4427897b3d228/grpclib/plugin/main.py#L174 and https://github.com/vmagamedov/grpclib/blob/5916cba69fc1f8a25fe8e749e3c4427897b3d228/grpclib/plugin/main.py#L251 that |python is appropriate.

Fixes #321

@github-actions github-actions bot added the lang-python Python rules specific label Jun 26, 2024
This reverts commit 8685ee8.
@aaliddell
Copy link
Member

Excellent thanks. Regarding testing, there is a test workspace specifically for Python with dashes in paths, just grpclib was missed there: https://github.com/rules-proto-grpc/rules_proto_grpc/tree/master/test_workspaces/python_dashes

I'll update that test workspace to encompass grpclib too

@aaliddell aaliddell merged commit 85bc1ff into rules-proto-grpc:master Jul 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-python Python rules specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpclib output is empty for proto paths with dashes
2 participants