Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #62 #68

Closed
wants to merge 1 commit into from
Closed

fixed issue #62 #68

wants to merge 1 commit into from

Conversation

Di-ref
Copy link

@Di-ref Di-ref commented Jul 26, 2020

fixed issue #62 by eliminating some empty comments that are triggering a bug in the Scrapy library.
link to the issue in the Scrapy repository

@Di-ref Di-ref changed the title fixing issue #62 fixed issue #62 Jul 26, 2020
@ACLemain
Copy link

Hi @Di-ref - I cloned your fbcrawl fork, but I still get the error:
...\anaconda3\envs\Facebook\lib\ast.py", line 47, in parse
return compile(source, filename, mode, flags,
File "", line 1
def parse_page(self, response):
^

Or did you fix it elsewhere?

@Di-ref
Copy link
Author

Di-ref commented Nov 6, 2020

Hi @Di-ref - I cloned your fbcrawl fork, but I still get the error:
...\anaconda3\envs\Facebook\lib\ast.py", line 47, in parse
return compile(source, filename, mode, flags,
File "", line 1
def parse_page(self, response):
^

Or did you fix it elsewhere?

Hi, after some investigation it turns out that some empty docstrings actually triggering a bug in an older version of the Scrapy library (which was fixed btw), but it seems like the code for fbcrawl is no longer maintained to undergo these changes and i dont think it will be updated any time soon, unfortunately.

@Di-ref Di-ref closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants