avm2: Add style sheet support for TextField #19143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
|
Somebody should check #14832! |
kjarosh
force-pushed
the
edittext-stylesheet
branch
from
f6b3a6b to
47b37a3
Compare
kjarosh
force-pushed
the
edittext-stylesheet
branch
2 times, most recently
from
36e761b to
c5a379f
Compare
|
Before merging, I'm thinking I unnecessarily rewrote |
This makes it easier to access style sheet in Rust.
This patch adds TextField.styleSheet support. Now when parsing HTML, the attached style sheet is used to provide styles for HTML elements. This patch also adds support for: * `class` attributes in HTML, * `<span>` HTML elements, * custom HTML elements. CSS support is spanned across all existing HTML elements and custom ones. Additionally, some observable behaviors related to .styleSheet are implemented, e.g. performing relayout after setting .styleSheet, or .text behaving as .htmlText with style sheet set. Currently, the implementation is coupled with AVM2 objects, that should change when AVM1 support is added.
This test verifies the behavior of TextField.styleSheet
kjarosh
force-pushed
the
edittext-stylesheet
branch
from
c5a379f to
9fa05d2
Compare
|
Simplified the code in the second commit a lot. Sorry for the trouble @Dinnerbone ! (but I think it was worth it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
TextField.styleSheetsupport. Now when parsing HTML, the attached style sheet is used to provide styles for HTML elements.This patch also adds support for:
classattributes in HTML,<span>HTML elements,CSS support is spanned across all existing HTML elements and custom ones.
Additionally, some observable behaviors related to
.styleSheetare implemented, e.g. performing relayout after setting.styleSheet, or .text behaving as.htmlTextwith style sheet set.Currently, the implementation is coupled with AVM2 objects, that should change when AVM1 support is added.