core: Improve order of automatic tab ordering #15810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
added
the
waiting-on-review
This patch improves the order of automatic tab ordering, and makes it behave more like in FP. The order after this patch is far from being exactly the same as in FP, but is close enough.
This test tests a grid with randomized (x,y) positions, depths, and SWF tag positions. It proves that mainly the position on the screen determines the automatic order.
This test verifies the behavior of duplicate (x,y) positions of objects. Turns out, FP actually ignores other objects with the same position, retaining only the first one.
torokati44
force-pushed
the
tab-ordering-order
branch
from
b0ba082 to
baf50df
Compare
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443.
This patch improves the order of automatic tab ordering, and makes it behave more like in FP. The order after this patch is far from being exactly the same as in FP, but is close enough.
In reality, FP sometimes jumps up with the focus or even ignores some arbitrary objects. However, the exact behavior is very complicated and requires a lot more testing and analysis.