Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should optimize cases where there's a lot of text left to be scrolled under the textfield. The speedup can be extreme if there are hundreds of pointlessly-drawn lines.
(However, note that this doesn't help with the opposite case - when you scroll to the bottom, it'll still draw all the text :/ )
The perfect solution might be to implement all 4 types of culling (lines under/above* textfield/screen), but with all the transforms, height metrics etc etc this was the only one I could confidently implement - and even in this one I'm not convinced I didn't skip any edge cases.
(Note that due to how
scrollV
works, lines above the textfield could be skipped without even iterating over them. In fact... maybe FP (and us) could deduce in-bounds for each glyph, thus making us not require masking at all?)