[WIP] chore: use reuseconn linter instead of bodyclose #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
force-pushed
the
chore.reuseconn
branch
4 times, most recently
from
0514bbf to
5d88984
Compare
atzoum
force-pushed
the
chore.reuseconn
branch
from
5d88984 to
acfd1c1
Compare
Codecov ReportBase: 47.42% // Head: 47.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2851 +/- ##
==========================================
+ Coverage 47.42% 47.53% +0.10%
==========================================
Files 310 310
Lines 49653 49674 +21
==========================================
+ Hits 23548 23611 +63
+ Misses 24668 24617 -51
- Partials 1437 1446 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
reuseconninstead ofbodyclose, to ensure that http response's are properly disposed (consumed & closed) by a single function call.Need to wait until the linter is included in golangci-lint (relevant pr here)
Security