fix: add standard events to reddit #1873
Conversation
aanshi07
requested review from
lvrach,
cisse21,
debanjan97,
am6010,
ssbeefeater,
ItsSudip,
sandeepdsvs,
krishna2020 and
1abhishekpandey
as code owners
WalkthroughThe pull request introduces enhancements to the Reddit destination configuration by adding new event mapping options for the "SignUp" and "Lead" events. These modifications allow users to map additional RudderStack events to corresponding Reddit events. The changes are implemented in the UI configuration file and the validation test data, ensuring the new mapping options are supported and validated without altering existing configurations. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1873 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/data/validation/destinations/reddit.json (1)
291-303: LGTM! Consider adding negative test cases.The test case properly validates the new SignUp event mapping with correct configuration structure.
Consider adding negative test cases to validate:
- Invalid event mapping (e.g., incorrect "to" value)
- Case sensitivity handling (e.g., "signup" vs "SignUp")
{ "config": { "accountId": "d2bnpxxxxxzq1p89hXXXXx2hf5q1k3v", "hashData": true, "eventsMapping": [ { "from": "Sign up", "to": "SignUp" } ] }, "result": true }, +{ + "config": { + "accountId": "d2bnpxxxxxzq1p89hXXXXx2hf5q1k3v", + "hashData": true, + "eventsMapping": [ + { + "from": "Sign up", + "to": "signup" + } + ] + }, + "result": false, + "err": ["Invalid Reddit event name"] +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/configurations/destinations/reddit/ui-config.json(1 hunks)test/data/validation/destinations/reddit.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
src/configurations/destinations/reddit/ui-config.json (1)
135-138: LGTM! Verify standard event name.The addition of the "SignUp" event mapping option follows the existing pattern and structure correctly.
Let's verify this is a standard Reddit event name:
✅ Verification successful
"SignUp" appears to be a valid standard event name
The event follows the same naming convention and structure as other standard Reddit events like ViewContent, Search, AddToCart, etc., and represents a common conversion action type.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for documentation or references to Reddit's standard events # to verify "SignUp" is an official event name curl -s "https://advertising.reddithelp.com/en/categories/measuring-optimizing/installing-reddit-pixel" | grep -i "signup"Length of output: 120
Script:
#!/bin/bash # Search for Reddit event configurations and documentation echo "=== Searching for Reddit event configurations ===" rg -i "signup" --type json src/configurations/destinations/reddit/ echo -e "\n=== Searching for Reddit documentation files ===" fd -e md -e txt -e json . src/configurations/destinations/reddit/ -x grep -i "signup" {} \; echo -e "\n=== Checking for similar event patterns ===" rg '"value":\s*"[^"]*"' src/configurations/destinations/reddit/ui-config.jsonLength of output: 1283
aanshi07
changed the title
What are the changes introduced in this PR?
Added standard event to Reddit
What is the related Linear task?
Resolves INT-3093
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit
New Features
Tests