chore: add custom domain url labels for gtm and ga4 #1867
Conversation
yashasvibajpai
requested review from
lvrach,
cisse21,
debanjan97,
am6010,
ssbeefeater,
ItsSudip,
sandeepdsvs,
krishna2020 and
1abhishekpandey
as code owners
WalkthroughThe pull request involves updating the user interface configuration for two destination configurations: GA4 and Google Tag Manager (GTM). The changes focus on renaming a specific field label from "SDK Base URL" or "Server Container URL" to "Custom Domain URL" in their respective Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/configurations/destinations/ga4/ui-config.json (1)
126-133: Consider renaming the configKey for better maintainability.While the changes look good, the configKey
sdkBaseUrlno longer matches the UI labelCustom Domain URL. Consider renaming it tocustomDomainUrlin a future update for better code maintainability. Note that this would require a migration strategy to handle existing configurations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/configurations/destinations/ga4/ui-config.json(1 hunks)src/configurations/destinations/gtm/ui-config.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/configurations/destinations/gtm/ui-config.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
src/configurations/destinations/ga4/ui-config.json (1)
126-126: LGTM! Consider updating related documentation.The label change from "SDK Base URL" to "Custom Domain URL" improves clarity. However, ensure that any related documentation or guides referencing the old "SDK Base URL" terminology are updated to maintain consistency.
Run the following script to find documentation that might need updates:
Also applies to: 130-130
✅ Verification successful
No documentation updates required
The label change from "SDK Base URL" to "Custom Domain URL" is purely UI-focused. The only references to the old terminology are in internal configuration files and historical changelog entries, which should be preserved for backward compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for references to "SDK Base URL" in documentation rg -i "sdk base url" --type mdLength of output: 273
Script:
#!/bin/bash # Search for references to sdkBaseUrl in comments and JSON files rg -i "sdkBaseUrl" --type js --type ts --type jsx --type tsx -g '!*.json' -C 2 rg -i "sdkBaseUrl" --type json -g '!**/package*.json' -g '!**/tsconfig*.json'Length of output: 944
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1867 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
What are the changes introduced in this PR?
Add custom domain url labels for gtm and ga4
What is the related Linear task?
Resolves INT-3112
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit