Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve schema generator #1207

Merged
merged 42 commits into from
Apr 30, 2024

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Feb 13, 2024

What are the changes introduced in this PR?

Improvements:

  • Added a warning for missing fields in db-config.json but found in ui-config.json.
  • Fixed the generation of the useNativeSDK field always.
  • Fixed the issue where the schema is generated for a field even though it is not present in the db-config.json file.

Also, deleted duplicate enum value for a field in Snap Pixel destination.

What is the related Linear task?

Resolves INT-1591

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

saikumarrs and others added 30 commits December 18, 2023 16:28
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@saikumarrs saikumarrs removed the Stale label Apr 26, 2024
@saikumarrs saikumarrs merged commit 55ad8d7 into develop Apr 30, 2024
8 checks passed
@saikumarrs saikumarrs deleted the feat.improve-schema-generator-int-1591 branch April 30, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants