Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add PR template #1106

Merged
merged 9 commits into from
Dec 27, 2023
Merged

chore: add PR template #1106

merged 9 commits into from
Dec 27, 2023

Conversation

yashasvibajpai
Copy link
Member

Description of the change

Updating the PR template.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • I have executed schemaGenerator tests and updated schema if needed

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai self-assigned this Dec 8, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a66fb5) 100.00% compared to head (391cab2) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

koladilip
koladilip previously approved these changes Dec 11, 2023
View reviewed changes
@yashasvibajpai yashasvibajpai deleted the chore.add.pr.template branch December 13, 2023 14:46
@yashasvibajpai yashasvibajpai restored the chore.add.pr.template branch December 13, 2023 20:57
@yashasvibajpai yashasvibajpai merged commit 4ecd461 into main Dec 27, 2023
6 checks passed
@yashasvibajpai yashasvibajpai deleted the chore.add.pr.template branch December 27, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@krishna2020 krishna2020 krishna2020 approved these changes

@koladilip koladilip koladilip left review comments

@ItsSudip ItsSudip Awaiting requested review from ItsSudip ItsSudip is a code owner

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs sandeepdsvs is a code owner

@nidhilashkari17 nidhilashkari17 Awaiting requested review from nidhilashkari17

@lvrach lvrach Awaiting requested review from lvrach lvrach is a code owner

@bardisg bardisg Awaiting requested review from bardisg

Assignees

@yashasvibajpai yashasvibajpai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashasvibajpai @krishna2020 @koladilip @shrouti1507