fix: fixing minor issues

rudderlabs · Jan 22, 2025 · 54d2d3c · 54d2d3c
1 parent cf36357
commit 54d2d3c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 90 deletions.
diff --git a/src/configurations/destinations/customerio_segment/db-config.json b/src/configurations/destinations/customerio_segment/db-config.json
@@ -9,7 +9,7 @@
     "syncBehaviours": ["mirror"],
     "transformAtV1": "router",
     "saveDestinationResponse": true,
-    "includeKeys": ["oneTrustCookieCategories", "consentManagement"],
+    "includeKeys": ["oneTrustCookieCategories", "ketchConsentPurposes", "consentManagement"],
     "excludeKeys": [],
     "supportedSourceTypes": ["warehouse"],
     "supportedMessageTypes": {
@@ -31,6 +31,10 @@
     "secretKeys": ["appApiKey", "apiKey"]
   },
   "options": {
-    "isBeta": true
+    "isBeta": true,
+    "hidden": {
+      "featureFlagName": "AMP_customerio_segment_v2",
+      "featureFlagValue": false
+    }
   }
 }
diff --git a/src/configurations/destinations/customerio_segment/schema.json b/src/configurations/destinations/customerio_segment/schema.json
@@ -6,15 +6,15 @@
     "properties": {
       "apiKey": {
         "type": "string",
-        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,500})$"
+        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
       },
       "appApiKey": {
         "type": "string",
-        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,200})$"
+        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$"
       },
       "siteId": {
         "type": "string",
-        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,200})$"
+        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
       },
       "oneTrustCookieCategories": {
         "type": "object",

diff --git a/src/configurations/destinations/customerio_segment/ui-config.json b/src/configurations/destinations/customerio_segment/ui-config.json
@@ -14,10 +14,10 @@
                 "fields": [
                   {
                     "type": "textInput",
-                    "label": "Customer.io Site ID",
+                    "label": "Site ID",
                     "note": "Settings > Account Settings > API Credentials > Track APP Keys > Site ID",
                     "configKey": "siteId",
-                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,500})$",
+                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
                     "regexErrorMessage": "Invalid Site Id",
                     "placeholder": "e.g: 88f02580XXXXXXXcf18",
                     "secret": true
@@ -35,9 +35,9 @@
                   {
                     "type": "textInput",
                     "label": "APP API Key",
-                    "note": "Settings > Account Settings > API Credentials > APP API Keys > API KEY of the corresponding Site ID",
+                    "note": "Settings > Account Settings > API Credentials > APP API Keys > API KEY",
                     "configKey": "appApiKey",
-                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
+                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$",
                     "regexErrorMessage": "Invalid Ad Account id",
                     "placeholder": "e.g: 2309XXX5483",
                     "secret": true
@@ -72,37 +72,6 @@
         "title": "Configuration settings",
         "note": "Manage the settings for your destination",
         "sections": [
-          {
-            "title": "Destination settings",
-            "note": "Configure advanced destination-specific settings here",
-            "icon": "settings",
-            "groups": [
-              {
-                "title": "Event Settings",
-                "note": "Configure event-specific settings here",
-                "fields": [
-                  {
-                    "type": "textInput",
-                    "label": "App Secret",
-                    "note": "Provide App Secret from your Facebook Developer App's basic settings.",
-                    "configKey": "appSecret",
-                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,200})$",
-                    "regexErrorMessage": "Invalid App Secret",
-                    "placeholder": "e.g: f65c45d8e013faXXXXXe1759c123456",
-                    "secret": true
-                  },
-                  {
-                    "type": "textInput",
-                    "label": "Audience Batch Size",
-                    "configKey": "maxUserCount",
-                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
-                    "regexErrorMessage": "Invalid Audience Batch Size",
-                    "default": "10000"
-                  }
-                ]
-              }
-            ]
-          },
           {
             "id": "consentSettings",
             "title": "Consent settings",
@@ -122,56 +91,6 @@
       "title": "Consent settings",
       "note": "not visible in the ui",
       "fields": [
-        {
-          "type": "tagInput",
-          "label": "OneTrust consent category IDs",
-          "note": "Input your OneTrust category IDs by pressing 'Enter' after each entry. The support for category names is deprecated. We recommend using the category IDs instead of the names as IDs are unique and less likely to change over time, making them a more reliable choice.",
-          "configKey": "oneTrustCookieCategories",
-          "tagKey": "oneTrustCookieCategory",
-          "placeholder": "e.g: C0001",
-          "default": [
-            {
-              "oneTrustCookieCategory": ""
-            }
-          ],
-          "preRequisites": {
-            "featureFlags": [
-              {
-                "configKey": "AMP_enable-gcm",
-                "value": false
-              },
-              {
-                "configKey": "AMP_enable-gcm"
-              }
-            ],
-            "featureFlagsCondition": "or"
-          }
-        },
-        {
-          "type": "tagInput",
-          "label": "Ketch consent purpose IDs",
-          "note": "Input your Ketch consent purpose IDs by pressing 'Enter' after each entry.",
-          "configKey": "ketchConsentPurposes",
-          "tagKey": "purpose",
-          "placeholder": "e.g: marketing",
-          "default": [
-            {
-              "purpose": ""
-            }
-          ],
-          "preRequisites": {
-            "featureFlags": [
-              {
-                "configKey": "AMP_enable-gcm",
-                "value": false
-              },
-              {
-                "configKey": "AMP_enable-gcm"
-              }
-            ],
-            "featureFlagsCondition": "or"
-          }
-        },
         {
           "type": "dynamicCustomForm",
           "configKey": "consentManagement",