Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: throttling tagger #730

Merged
merged 2 commits into from
Jan 29, 2025
Merged

chore: throttling tagger #730

merged 2 commits into from
Jan 29, 2025

Conversation

fracasula
Copy link
Collaborator

@fracasula fracasula commented Jan 29, 2025 •
edited
Loading

Description

Adding a way to customize tags in throttler.

Updating go version as well to fix a few vulnerabilities in net/[email protected] and crypto/[email protected].

See here.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

mihir20
mihir20 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ktgowtham
ktgowtham approved these changes Jan 29, 2025
View reviewed changes
Copy link

@ktgowtham ktgowtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we want to remove key label from ingestion service?

@fracasula fracasula merged commit 26e7749 into main Jan 29, 2025
18 checks passed
@fracasula fracasula deleted the throttlingTagger branch January 29, 2025 14:47
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir20 mihir20 mihir20 approved these changes

@ktgowtham ktgowtham ktgowtham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fracasula @ktgowtham @mihir20