Skip to content

Commit

Permalink
Rubocop clean
Browse files Browse the repository at this point in the history
  • Loading branch information
bougyman committed Jan 25, 2024
1 parent 98b15a4 commit 1ecf236
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 14 deletions.
4 changes: 4 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
---
require:
- rubocop-rake
- rubocop-rspec

AllCops:
TargetRubyVersion: 3.3.0
NewCops: enable
Expand Down
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ group :development, :test do
gem "rake", "~> 13.0"
gem "rspec", "~> 3.0"
gem "rubocop", "~> 1.21"
gem "rubocop-rake", require: false
gem "rubocop-rspec", require: false
end
14 changes: 13 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
linear-cli (0.1.2)
linear-cli (0.1.3)
base64
dry-cli (~> 1.0)
dry-cli-completion (~> 1.0)
Expand Down Expand Up @@ -136,6 +136,16 @@ GEM
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.25.1)
rubocop (~> 1.41)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-rspec (2.26.1)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
ruby-progressbar (1.13.0)
semantic_logger (4.15.0)
concurrent-ruby (~> 1.0)
Expand All @@ -157,6 +167,8 @@ DEPENDENCIES
rake (~> 13.0)
rspec (~> 3.0)
rubocop (~> 1.21)
rubocop-rake
rubocop-rspec

BUNDLED WITH
2.5.3
8 changes: 1 addition & 7 deletions lib/linear/commands/issue/list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module Rubyists
module Linear
M :issue
M :user
# Namespace for CLI
module CLI
module Issue
List = Class.new Dry::CLI::Command
Expand All @@ -20,13 +21,6 @@ class List
def call(**options)
logger.debug "Listing issues"
display issues_for(options), options
rescue SmellsBad => e
logger.error e.message
exit 1
rescue StandardError => e
logger.error e.message
logger.error e.backtrace.join("\n") if Rubyists::Linear.verbosity > 0
exit 5
end

def issues_for(options)
Expand Down
2 changes: 1 addition & 1 deletion linear-cli.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
spec.summary = "CLI for interacting with Linear.app."
spec.description = "A CLI for interacting with Linear.app. Loosely based on the GitHub CLI"
spec.homepage = "https://github.com/rubyists/linear-cli"
spec.required_ruby_version = ">= 2.6.0"
spec.required_ruby_version = ">= 3.3.0"

spec.license = "MIT"
spec.metadata["allowed_push_host"] = "https://rubygems.org"
Expand Down
6 changes: 1 addition & 5 deletions spec/linear/cli_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

RSpec.describe Linear::Cli do
it "has a version number" do
expect(Linear::Cli::VERSION).not_to be nil
end

it "does something useful" do
expect(false).to eq(true)
expect(Linear::Cli::VERSION).not_to be_nil
end
end

0 comments on commit 1ecf236

Please sign in to comment.