Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support nested parameterizing rules #235

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/lrama/grammar.rb
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,8 @@ def replace_token_with_symbol
rule.lhs = token_to_symbol(rule._lhs) if rule._lhs

rule.rhs = rule._rhs.map do |t|
token_to_symbol(t)
end
token_to_symbol(t) unless t.is_a?(Lrama::Lexer::Token::Parameterizing)
end.compact
end
end

Expand Down
27 changes: 24 additions & 3 deletions lib/lrama/grammar/parameterizing_rules/builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,33 @@ def initialize(token, rule_counter, lhs, user_code, precedence_sym, line)
end

def build
if RULES.key?(@key)
RULES[@key].new(@token, @rule_counter, @lhs, @user_code, @precedence_sym, @line).build
else
validate_key!

rules = inside_rules
s_value = if rules.empty?
@token.args.first.s_value
else
rules.last._lhs.s_value
end
rules << RULES[@key].new(@token.args, s_value, @rule_counter, @lhs, @user_code, @precedence_sym, @line).build
rules.flatten
end

private

def validate_key!
unless RULES.key?(@key)
raise "Parameterizing rule does not exist. `#{@key}`"
end
end

def inside_rules
if @token.args.any? { |arg| arg.is_a?(Lrama::Lexer::Token::Parameterizing) }
ParameterizingRules::Builder.new(@token.args.first, @rule_counter, @lhs, @user_code, @precedence_sym, @line).build
else
[]
end
end
end
end
end
Expand Down
5 changes: 3 additions & 2 deletions lib/lrama/grammar/parameterizing_rules/builder/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ class Grammar
class ParameterizingRules
class Builder
class Base
def initialize(token, rule_counter, lhs, user_code, precedence_sym, line)
@args = token.args
def initialize(args, s_value, rule_counter, lhs, user_code, precedence_sym, line)
@args = args
@token = @args.first
@s_value = s_value
@rule_counter = rule_counter
@lhs = lhs
@user_code = user_code
Expand Down
2 changes: 1 addition & 1 deletion lib/lrama/grammar/parameterizing_rules/builder/list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def build
validate_argument_number!

rules = []
list_token = Lrama::Lexer::Token::Ident.new(s_value: "list_#{@token.s_value}")
list_token = Lrama::Lexer::Token::Ident.new(s_value: "list_#{@s_value}")
rules << Rule.new(id: @rule_counter.increment, _lhs: @lhs, _rhs: [list_token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: list_token, _rhs: [], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: list_token, _rhs: [list_token, @token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def build
validate_argument_number!

rules = []
nonempty_list_token = Lrama::Lexer::Token::Ident.new(s_value: "nonempty_list_#{@token.s_value}")
nonempty_list_token = Lrama::Lexer::Token::Ident.new(s_value: "nonempty_list_#{@s_value}")
rules << Rule.new(id: @rule_counter.increment, _lhs: @lhs, _rhs: [nonempty_list_token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: nonempty_list_token, _rhs: [@token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: nonempty_list_token, _rhs: [nonempty_list_token, @token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
Expand Down
2 changes: 1 addition & 1 deletion lib/lrama/grammar/parameterizing_rules/builder/option.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def build
validate_argument_number!

rules = []
option_token = Lrama::Lexer::Token::Ident.new(s_value: "option_#{@token.s_value}")
option_token = Lrama::Lexer::Token::Ident.new(s_value: "option_#{@s_value}")
rules << Rule.new(id: @rule_counter.increment, _lhs: @lhs, _rhs: [option_token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: option_token, _rhs: [], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: option_token, _rhs: [@token], token_code: @ser_code, precedence_sym: @precedence_sym, lineno: @line)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def build
validate_argument_number!

rules = []
separated_list_token = Lrama::Lexer::Token::Ident.new(s_value: "separated_list_#{@token.s_value}")
separated_list_token = Lrama::Lexer::Token::Ident.new(s_value: "separated_list_#{@s_value}")
rules << Rule.new(id: @rule_counter.increment, _lhs: @lhs, _rhs: [separated_list_token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: separated_list_token, _rhs: [], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: separated_list_token, _rhs: [@token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def build
validate_argument_number!

rules = []
separated_list_token = Lrama::Lexer::Token::Ident.new(s_value: "separated_nonempty_list_#{@token.s_value}")
separated_list_token = Lrama::Lexer::Token::Ident.new(s_value: "separated_nonempty_list_#{@s_value}")
rules << Rule.new(id: @rule_counter.increment, _lhs: @lhs, _rhs: [separated_list_token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: separated_list_token, _rhs: [@token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
rules << Rule.new(id: @rule_counter.increment, _lhs: separated_list_token, _rhs: [separated_list_token, @separator, @token], token_code: @user_code, precedence_sym: @precedence_sym, lineno: @line)
Expand Down
2 changes: 1 addition & 1 deletion lib/lrama/grammar/rule_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def build_rules

# Expand Parameterizing rules
if tokens.any? {|r| r.is_a?(Lrama::Lexer::Token::Parameterizing) }
@rules = @parameterizing_rules
@rules = parameterizing_rules
@midrule_action_rules = []
else
rule = Rule.new(
Expand Down
Loading