Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract C_DECLARATION end process to a private method #170

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Extract C_DECLARATION end process to a private method #170

merged 3 commits into from
Oct 31, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Oct 30, 2023 •
edited
Loading

Follow up: 9eff504

@yui-knk
Copy link
Collaborator

yui-knk commented Oct 30, 2023

These are clean up processes for C_DECLARATION because actions ({...}) after C_DECLARATION are executed after C_DECLARATION is determined. Could you rethink the name of the method?

@ydah ydah changed the title Extract C_DECLARATION begin process to a private method Extract C_DECLARATION end process to a private method Oct 31, 2023
@ydah
Copy link
Member Author

ydah commented Oct 31, 2023

Oops, sorry. I change to use end. What do you think?

@yui-knk
Copy link
Collaborator

yui-knk commented Oct 31, 2023

Seems good, thank you!

@yui-knk yui-knk merged commit 641f4f6 into ruby:master Oct 31, 2023
@ydah ydah deleted the refactor-c_declaration branch October 31, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydah @yui-knk