Merge pull request #486 from yui-knk/fix_find_symbol_by_s_value_arg_type

Fix argument type of `find_symbol_by_s_value` and `find_symbol_by_s_value!`
ruby · Dec 22, 2024 · 9cb2e6f · 9cb2e6f
2 parents ee0cd74 + cb9f509
commit 9cb2e6f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sig/lrama/grammar.rbs b/sig/lrama/grammar.rbs
@@ -102,7 +102,7 @@ module Lrama
     def symbols: () -> Array[Grammar::Symbol]
     def terms: () -> Array[Grammar::Symbol]
     def nterms: () -> Array[Grammar::Symbol]
-    def find_symbol_by_s_value!: (Grammar::Symbol s_value) -> Grammar::Symbol
+    def find_symbol_by_s_value!: (::String s_value) -> Grammar::Symbol
     end
   end
 end
diff --git a/sig/lrama/grammar/symbols/resolver.rbs b/sig/lrama/grammar/symbols/resolver.rbs
@@ -14,8 +14,8 @@ module Lrama
         def sort_by_number!: () -> Array[Grammar::Symbol]
         def add_term: (id: Lexer::Token, ?alias_name: String?, ?tag: Lexer::Token::Tag?, ?token_id: Integer?, ?replace: bool) -> Grammar::Symbol
         def add_nterm: (id: Lexer::Token, ?alias_name: String?, ?tag: Lexer::Token::Tag?) -> Grammar::Symbol
-        def find_symbol_by_s_value: (Grammar::Symbol s_value) -> Grammar::Symbol?
-        def find_symbol_by_s_value!: (Grammar::Symbol s_value) -> Grammar::Symbol
+        def find_symbol_by_s_value: (::String s_value) -> Grammar::Symbol?
+        def find_symbol_by_s_value!: (::String s_value) -> Grammar::Symbol
         def find_symbol_by_id: (Lexer::Token id) -> Grammar::Symbol?
         def find_symbol_by_id!: (Lexer::Token id) -> Grammar::Symbol
         def find_symbol_by_token_id: (Integer token_id) -> Grammar::Symbol?
@@ -47,7 +47,7 @@ module Lrama
         def find_symbol_by_number!: (Integer number) -> Grammar::Symbol
         def find_symbol_by_id!: (Lexer::Token id) -> Grammar::Symbol
         def token_to_symbol: (Lexer::Token token) -> Grammar::Symbol
-        def find_symbol_by_s_value!: (Grammar::Symbol s_value) -> Grammar::Symbol
+        def find_symbol_by_s_value!: (::String s_value) -> Grammar::Symbol
         def fill_nterm_type: (Array[Grammar::Type] types) -> void
         def fill_symbol_number: () -> void
         def fill_printer: (Array[Grammar::Printer] printers) -> void