Fix _derivations to be non-null

Co-authored-by: yui-knk <[email protected]>
ruby · Dec 21, 2024 · 613c68e · 613c68e
1 parent 8668c40
commit 613c68e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/lrama/counterexamples/example.rb b/lib/lrama/counterexamples/example.rb
@@ -38,7 +38,7 @@ def derivations2
       private
 
       def _derivations(paths)
-        derivation = nil #: Derivation?
+        derivation = nil #: Derivation
         current = :production
         last_path = paths.last #: Path
         lookahead_sym = last_path.to.item.end_of_rule? ? @conflict_symbol : nil
@@ -59,7 +59,7 @@ def _derivations(paths)
               derivation = Derivation.new(item, derivation)
               current = :production
             else
-              return nil
+              raise "Unexpected. #{path}"
             end
 
             if lookahead_sym && item.next_next_sym && item.next_next_sym.first_set.include?(lookahead_sym)

diff --git a/sig/lrama/counterexamples/example.rbs b/sig/lrama/counterexamples/example.rbs
@@ -31,13 +31,13 @@ module Lrama
 
       def path2_item: () -> States::Item
 
-      def derivations1: () -> Derivation?
+      def derivations1: () -> Derivation
 
-      def derivations2: () -> Derivation?
+      def derivations2: () -> Derivation
 
       private
 
-      def _derivations: (::Array[StartPath | TransitionPath | ProductionPath] paths) -> Derivation?
+      def _derivations: (::Array[StartPath | TransitionPath | ProductionPath] paths) -> Derivation
 
       def find_derivation_for_symbol: (StateItem state_item, Grammar::Symbol sym) -> Derivation?
     end