Support renaming custom templates with ore install URI [TEMPLATE_NAME]
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Module::Common is now the home of the `ROOT` constant and the `#cleanup!` method. * `ROOT` is now a `Pathname` object rather than a string. * `#have_git?` returns true if the `git` executable can be located, false otherwise. * `#from_root_path` returns a `Pathname` object under the `ROOT` path.
This repository is for use in verifying the behavior of `ore install`.
`cli install` now recognizes an optional second parameter that, when provided, is used as the subdirectory of `~/.ore/templates` into which the template repo will be cloned.
Verify that `ore install` clones templates to the expected locations depending on whether or not the optional basename parameter was provided.
tomeon
changed the title
ore installore install URI [TEMPLATE_NAME]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for assigning custom names to templates installed with
ore install. The idea is that you can name your repository something likevagrant_plugin_ore_template.git, but clone it into the directory~/.ore/templates/vagrant_plugin. This way,minewill expose the options--vagrant-pluginand--no-vagrant-pluginrather than--vagrant-plugin-ore-templateand--no-vagrant-plugin-ore-template.I've added a nearly-bare git repository as a testing fixture in order to permit running
ore installduring tests without having to hit the network. If this is overkill, I am happy to replace the local repo with an external repo; perhaps one of theruby-oreorg's custom templates?Thanks in advance for your consideration!