Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-19: Plugin Update #18

Merged
merged 6 commits into from
Dec 14, 2023
Merged

GH-19: Plugin Update #18

merged 6 commits into from
Dec 14, 2023

Conversation

SH4LIN
Copy link
Contributor

@SH4LIN SH4LIN commented Dec 6, 2023 •
edited
Loading

  • This PR will update the PHP Code Version to 8.2
    • Added return types to the function along with the function parameter types.
  • Fixed the PHPCS issues.
  • Fixed the WordPress VIP Go warning of using vip_safe_wp_remote_get() function.

Fixes/covers:

vishalkakadiya
vishalkakadiya approved these changes Dec 7, 2023
View reviewed changes
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SH4LIN Looks good to me. Just QA this well before launching this.

@SH4LIN SH4LIN changed the title Update: PHP Version 8.2 GH-19: Plugin Update Dec 13, 2023
@SH4LIN
Copy link
Contributor Author

SH4LIN commented Dec 13, 2023

@vishalkakadiya I have tested the plugin. But updated couple of things.

  1. readme.txt
  2. README.md

Resolved the merge conflict so can you please re-review this PR.

@SH4LIN SH4LIN merged commit 4b8e8f2 into develop Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalkakadiya vishalkakadiya vishalkakadiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SH4LIN @vishalkakadiya