-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5 compat #17
v5 compat #17
Conversation
This looks great. It seems to make this fully functional we will need to import the deserialize + transforms process from redux-persist. This is not currently exported but it could be. |
@rt2zz If you merge rt2zz/redux-persist#620 and ship a release I can finish this up in no time |
@rt2zz ? |
What's the status of this? |
@markopol0 It's ready to go I'm just waiting on a maintainer for merges. @rt2zz I hope you're okay my dude! |
Can confirm this works. The README should be updated with the new usage: crosstabSync(store, persistorConfig, crosstabConfig); Another point to add would be that this only works with localStorage, and not others like localForage. |
Is it compatible with transformers like https://github.com/rt2zz/redux-persist-transform-immutable ? I think it should be added
|
@rt2zz would be great to get |
Can we get a merge please? |
Agreed! Merge would be really nice. :-) |
@rt2zz |
Hi all, sorry for the slowness here, cutting a next release now. Please confirm if this is working for you if we get a couple of 👍 I will do a proper release |
|
was trying this out and got an error because of flow type.. i opened #21 to remove them, since we can't assume that end user will have flow type as part of their build process.. |
Not sure exactly what needs to be done to get a PR in here as there are no tests or guidelines but here is the crosstab persist I wrote for our app for v5. From conversation in #15 and rt2zz/redux-persist#569
I’m using it like this: