Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more human readable snapshots with tests #1927

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Nov 27, 2024

Will be much easier to inspect the diff now.

The only change is to make render_as_html() use cat()

My goal is to inspect the tests that are long and see if we could make the tests shorter.

Also, if we change what html output gt is emiting, it will be much easier to see what changed

I am seeing that there are always two new lines at the end of snapshots. maybe we could remove them.

@olivroy olivroy requested a review from rich-iannone November 27, 2024 17:54
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone
Copy link
Member

This is much better, thanks! Those extra line breaks before the closing </table> tag are really more visible now (and it seems like they are present if there aren't any <tfoot> tags).

@rich-iannone rich-iannone merged commit 31c1632 into rstudio:master Nov 27, 2024
12 checks passed
@olivroy olivroy deleted the snap branch November 27, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants