Fix #1582 #1595
Merged
Fix #1582 #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kbrevoort , thanks again for your work on the LaTeX parts of the package. To pick this one up where you left off, would you mind regenerating the snapshot (if the output is okay) to settle the merge conflict? I could then review and potentially merge. |
|
@rich-iannone I've resolved the merge conflict, but I'm having trouble understanding why there's still one check failing. Any insights? |
|
Thanks @kbrevoort ! The failure seems to be from a failure to build the magick package using R 3.6 in Windows. This is totally out of our control so we can safely ignore this. I’ll review the PR later in the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small fix to correct a bug reported in #1582. Column widths reported in pixels were being output to LaTeX in pixels, which causes an error because LaTeX does not recognize pixel measurements. I added a line to convert the widths to pts and use those in LaTeX. I also made some corresponding changes to a small number of testthat snapshots that were expecting LaTeX output with widths expressed as pixels to now expect widths in points.
Related GitHub Issues and PRs
cols_width()inpx()fails for Quarto PDF output (illegal unit of measure) #1582Checklist
testthatunit tests totests/testthatfor any new functionality.Fixes: #1582