Replace px with pt to fix Bug #1590 #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in PR rstudio#1470 but used px instead of pt causing the problem to persist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue addresses Issue #1590 which was supposedly corrected by PR #1450. However, there was a typo in the code and the "px" units were not converted properly to "pt" values. This very small PR does that and I have confirmed that this resolves the bug in #1590.
Related GitHub Issues and PRs
tab_stub_indentbreaks pdf output in Quarto #1590Checklist
testthatunit tests totests/testthatfor any new functionality.Fixes: #1590