Merge pull request #1661 from olivroy/rm-error

Improve error message for `rm_spanners()`, `rm_footnotes()`, and `rm_source_notes()`
rstudio · May 14, 2024 · 6f2ae5e · 6f2ae5e
2 parents 18b06ab + fd8c707
commit 6f2ae5e
Show file tree

Hide file tree

Showing 3 changed files with 85 additions and 60 deletions.
diff --git a/R/tab_remove.R b/R/tab_remove.R
@@ -301,7 +301,8 @@ rm_spanners <- function(
       as.integer(
         resolve_vector_i(
           expr = {{ spanners }},
-          vector = spanners_tbl[["spanner_id"]]
+          vector = spanners_tbl[["spanner_id"]],
+          "spanner"
         )
       )
 
@@ -498,7 +499,8 @@ rm_footnotes <- function(
     as.integer(
       resolve_vector_i(
         expr = {{ footnotes }},
-        vector = as.character(seq_len(footnotes_count))
+        vector = as.character(seq_len(footnotes_count)),
+        "footnote"
       )
     )
 
@@ -649,7 +651,8 @@ rm_source_notes <- function(
     as.integer(
       resolve_vector_i(
         expr = {{ source_notes }},
-        vector = as.character(seq_len(source_notes_length))
+        vector = as.character(seq_len(source_notes_length)),
+        "source note"
       )
     )