Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook-addon-rslib): use correct file extensions in exports object in package.json #205

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

mdrobny
Copy link
Contributor

@mdrobny mdrobny commented Dec 29, 2024

Why

because currently addon doesn't work because the defined cjs file doesn't exist in dist

Error when running Storybook

> storybook dev -p 6006

@storybook/core v8.4.7

WARN Could not resolve addon "storybook-addon-rslib", skipping. Is it installed?

…object in package.json

- because currently addon doesn't work because the defined `cjs` file doesn't exist in dist
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for storybook-rsbuild canceled.

Name Link
🔨 Latest commit ff18e11
🔍 Latest deploy log https://app.netlify.com/sites/storybook-rsbuild/deploys/677140149a0eb60008e565ec

@mdrobny
Copy link
Contributor Author

mdrobny commented Dec 30, 2024

@fi3ework this bug fix is more important, addon is not working currently from my perspective 😄

@fi3ework
Copy link
Member

What astonishes me is that, even under these circumstances, the addon still functions correctly. I have no idea how Storybook internally resolves the preset.

Thank you.

@fi3ework fi3ework merged commit 5fa0939 into rspack-contrib:main Dec 30, 2024
7 checks passed
@mdrobny mdrobny deleted the fix/rslib-addon-exports branch December 30, 2024 11:54
@mdrobny
Copy link
Contributor Author

mdrobny commented Dec 30, 2024

@fi3ework is the release of new version coming? Because it didn't happen automatically

@fi3ework
Copy link
Member

in hours I'll do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants