Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook-addon-rslib): update @rslib/core peerDependency to support v0.2 also #204

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

mdrobny
Copy link
Contributor

@mdrobny mdrobny commented Dec 28, 2024

Why

because >= 0.1.1 constraint actually causes error during npm install - NPM doesn't allow version 0.2 despite very open constraint

I have "@rslib/core": "^0.2.2", in my dependencies and doing npm i -D storybook-addon-rslib causes error

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: <<<some-package>>>
npm ERR! Found: @rslib/[email protected]
npm ERR! node_modules/@rslib/core
npm ERR!   dev @rslib/core@"^0.2.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @rslib/core@"^0.1.1" from [email protected]
npm ERR! node_modules/storybook-addon-rslib
npm ERR!   dev storybook-addon-rslib@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

seems like >= operator works differently in peerDependencies, it converts to "@rslib/core": "^0.1.1", it seems because that's what I see in node_modules if I do force install

Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for storybook-rsbuild canceled.

Name Link
🔨 Latest commit be1ab21
🔍 Latest deploy log https://app.netlify.com/sites/storybook-rsbuild/deploys/67727fa14c1c980008ff8183

- because `>= 0.1.1` constraint actually causes error during npm install - NPM doesn't allow version 0.2 despite very open constraint
@mdrobny mdrobny force-pushed the fix/rslib-addon-peer-dep branch from 9096880 to 7cd7239 Compare December 30, 2024 08:05
@mdrobny mdrobny changed the title fix(storybook-addon-rslib): update @rslib/core peerDependency to v0.2 fix(storybook-addon-rslib): update @rslib/core peerDependency to support v0.2 also Dec 30, 2024
@fi3ework fi3ework merged commit 121d858 into rspack-contrib:main Dec 30, 2024
7 checks passed
@mdrobny mdrobny deleted the fix/rslib-addon-peer-dep branch December 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants