fix: test comment

rspack-contrib · Oct 14, 2024 · ad5ca1d · ad5ca1d
1 parent 9c88328
commit ad5ca1d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 13 deletions.
diff --git a/.github/actions/build-rsbuild/action.yaml b/.github/actions/build-rsbuild/action.yaml
@@ -16,7 +16,7 @@ inputs:
   node-version:
     description: 'The version of Node.js to set up'
     required: true
-    default: '18'
+    default: '20'
 outputs:
   artifact-name:
     description: 'The name of the uploaded artifact'
@@ -25,7 +25,7 @@ runs:
   steps:
     - uses: actions/setup-node@v3
       with:
-        node-version: 18
+        node-version: 20
     - shell: bash
       name: Install package manager
       run: |

diff --git a/.github/workflows/ecosystem-ci-from-commit.yml b/.github/workflows/ecosystem-ci-from-commit.yml
@@ -69,14 +69,14 @@ jobs:
     strategy:
       matrix:
         include:
-          - suite: modernjs
-            os: ubuntu-latest
+          # - suite: modernjs
+          #   os: ubuntu-latest
           - suite: plugins
             os: ubuntu-latest
-          - suite: rspress
-            os: ubuntu-latest
-          - suite: rslib
-            os: ubuntu-latest
+          # - suite: rspress
+          #   os: ubuntu-latest
+          # - suite: rslib
+          #   os: ubuntu-latest
           - suite: examples
             os: ubuntu-latest
       fail-fast: false
@@ -150,3 +150,6 @@ jobs:
               repo: 'rsbuild',
               body
             })
+
+            console.log(`https://github.com/web-infra-dev/rsbuild/commit/${context.payload.inputs.commitSHA}#comments`)
+            return `https://github.com/web-infra-dev/rsbuild/commit/${context.payload.inputs.commitSHA}#comments`
diff --git a/tests/plugins.ts b/tests/plugins.ts
@@ -77,11 +77,11 @@ export async function test(options: RunOptions) {
 			test: [
 				'build',
 				async () => {
-					// if (hasTestScript) {
-					await $`pnpm run test`
-					// } else {
-					// 	console.warn(`not found test script in ${repo}`)
-					// }
+					if (hasTestScript) {
+						await $`pnpm run test`
+					} else {
+						console.warn(`not found test script in ${repo}`)
+					}
 				},
 			],
 		}).catch((err) => {