Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware SGX admin tooling #199

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

amendelzon
Copy link
Collaborator

  • Added Platform abstraction to manage common platform parameters
  • Added onboard support to HSM2DongleSGX
  • Implemented SGX admin tool
    • Implemented main SGX admin tool entrypoint with onboard, unlock, pin change and public key gathering commands
    • Misc get_hsm function now accounts for current Platform to acquire a connection
    • Updated specific admin modules to account for difference between platforms for specific operations
    • Now setting Platform within Ledger admin tool
  • Updated build scripts to account for SGX manager and admin
  • Replaced protocol platform-specific configuration for text messages with Platform messages
  • Added and updated unit tests

- Implemented main SGX admin tool entrypoint with onboard, unlock, pin change and public key gathering commands
- Misc get_hsm function now accounts for current Platform to acquire a connection
- Updated specific admin modules to account for difference between platforms for specific operations
- Now setting Platform within Ledger admin tool
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 0b951ed into feature/sgx-mvp Sep 18, 2024
4 checks passed
@amendelzon amendelzon deleted the feature/sgx-mvp--admintools branch September 18, 2024 14:33
amendelzon added a commit that referenced this pull request Oct 22, 2024
* Added onboard method to HSM2DongleSGX

* Added Platform abstraction to manage common platform parameters

* Replaced protocol platform-specific configuration for text messages with Platform messages

* Implemented SGX admin tool

- Implemented main SGX admin tool entrypoint with onboard, unlock, pin change and public key gathering commands
- Misc get_hsm function now accounts for current Platform to acquire a connection
- Updated specific admin modules to account for difference between platforms for specific operations
- Now setting Platform within Ledger admin tool

* Updated build scripts to account for SGX manager and admin

* Added and updated unit tests
amendelzon added a commit that referenced this pull request Oct 22, 2024
* Added onboard method to HSM2DongleSGX

* Added Platform abstraction to manage common platform parameters

* Replaced protocol platform-specific configuration for text messages with Platform messages

* Implemented SGX admin tool

- Implemented main SGX admin tool entrypoint with onboard, unlock, pin change and public key gathering commands
- Misc get_hsm function now accounts for current Platform to acquire a connection
- Updated specific admin modules to account for difference between platforms for specific operations
- Now setting Platform within Ledger admin tool

* Updated build scripts to account for SGX manager and admin

* Added and updated unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants