Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGX middleware manager #198

Merged
merged 2 commits into from
Sep 11, 2024
Merged

SGX middleware manager #198

merged 2 commits into from
Sep 11, 2024

Conversation

amendelzon
Copy link
Collaborator

For easier reviewing, I've split this into two separate commits:
1st - for general renaming of artifacts into more Ledger-specific names
2nd - for the actual SGX manager implementation

- Renamed manager and adm to manager_ledger and adm_ledger
- Renamed manager-tcp to manager_tcp for consistency (python doesn't like hyphens in module names)
- Renamed build scripts
- Protocol now accepts configurable "restart the powHSM" messages
- Updated tcpsigner bundle artifacts
- Updated unit tests
- Updated documentation
- Updated github workflows
- Updated .gitignore(s)
- Incidentally removed unnecessary file
- Added password changing capabilities to the SGX powHSM implementation
- Added main SGX manager script
- Added build script for the SGX manager
- Added password change and password retries getter commands to the HSM2DongleSGX
- Updated user options to make names more generic
- Added unit tests
- Updated middleware docker do script to expose the host to the container (allowing for running tests against e.g. an SGX powHSM simulator)
@amendelzon amendelzon force-pushed the feature/sgx-mvp--mware branch from 38abda6 to abeefd4 Compare September 10, 2024 13:45
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 2250e60 into feature/sgx-mvp Sep 11, 2024
4 checks passed
@amendelzon amendelzon deleted the feature/sgx-mvp--mware branch September 11, 2024 13:37
amendelzon added a commit that referenced this pull request Oct 22, 2024
- Renamed manager and adm to manager_ledger and adm_ledger
- Renamed manager-tcp to manager_tcp for consistency (python doesn't like hyphens in module names)
- Renamed build scripts
- Protocol now accepts configurable "restart the powHSM" messages
- Updated tcpsigner bundle artifacts
- Updated unit tests
- Updated documentation
- Updated github workflows
- Updated .gitignore(s)
- Incidentally removed unnecessary file
- Added password changing capabilities to the SGX powHSM implementation
- Added main SGX manager script
- Added build script for the SGX manager
- Added password change and password retries getter commands to the HSM2DongleSGX
- Updated user options to make names more generic
- Added unit tests
- Updated middleware docker do script to expose the host to the container (allowing for running tests against e.g. an SGX powHSM simulator)
amendelzon added a commit that referenced this pull request Oct 22, 2024
- Renamed manager and adm to manager_ledger and adm_ledger
- Renamed manager-tcp to manager_tcp for consistency (python doesn't like hyphens in module names)
- Renamed build scripts
- Protocol now accepts configurable "restart the powHSM" messages
- Updated tcpsigner bundle artifacts
- Updated unit tests
- Updated documentation
- Updated github workflows
- Updated .gitignore(s)
- Incidentally removed unnecessary file
- Added password changing capabilities to the SGX powHSM implementation
- Added main SGX manager script
- Added build script for the SGX manager
- Added password change and password retries getter commands to the HSM2DongleSGX
- Updated user options to make names more generic
- Added unit tests
- Updated middleware docker do script to expose the host to the container (allowing for running tests against e.g. an SGX powHSM simulator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants