Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'should reject a legacy pegin with the value exactly below minimum' #96

Closed

Conversation

jeremy-then
Copy link
Contributor

Adds a 'should reject a legacy pegin with the value exactly below minimum' test.

This test sends a pegin legacy with a value exactly below the minimum (the minimum pegin value minus 1 satoshis).

This tests is expected to not be marked as processed by the bridge and to emit a rejected_pegin event with the reason '5', which is 'invalid amount'.

With this test, we assert that the sender's derived rsk address does not have the funds, that the federation increases its funds but the funds are not refunded to the sender either.

@jeremy-then jeremy-then self-assigned this Sep 24, 2024
@jeremy-then jeremy-then requested a review from a team as a code owner September 24, 2024 15:26
@jeremy-then jeremy-then force-pushed the add-basic-peginv1-test branch 2 times, most recently from 0384627 to d0f3871 Compare September 30, 2024 18:43
@jeremy-then jeremy-then force-pushed the add-legacy-pegin-below-minimum-test branch from efd57b8 to 1a99856 Compare September 30, 2024 23:46
Copy link

@jeremy-then
Copy link
Contributor Author

New pr here: #107

@jeremy-then jeremy-then closed this Oct 2, 2024
@marcos-iov marcos-iov deleted the add-legacy-pegin-below-minimum-test branch October 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant