Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding repo owner input #103

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Adding repo owner input #103

merged 4 commits into from
Oct 10, 2024

Conversation

rmoreliovlabs
Copy link
Contributor

No description provided.

@rmoreliovlabs rmoreliovlabs requested a review from a team as a code owner September 30, 2024 14:30
jeremy-then
jeremy-then previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fmacleal
fmacleal approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, straight to the point but working fine. Well done!

fmacleal
fmacleal requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix to use the REPO_OWNER for powpeg as well.

container-action/entrypoint.sh Show resolved Hide resolved
@rmoreliovlabs rmoreliovlabs requested a review from fmacleal October 2, 2024 14:29
fmacleal
fmacleal previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general rule of thumb, I will approve, but check my comment about do the fix for powpeg as well. I believe we could fix both issues so we allow external contributors for both.

container-action/entrypoint.sh Show resolved Hide resolved
@rmoreliovlabs rmoreliovlabs dismissed stale reviews from fmacleal and jeremy-then via 8c98b2a October 3, 2024 14:58
@rmoreliovlabs rmoreliovlabs force-pushed the feature/adding_repo_owner_input branch from 8c98b2a to e8feff1 Compare October 3, 2024 15:27
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@marcos-iov marcos-iov merged commit e863324 into main Oct 10, 2024
7 checks passed
@marcos-iov marcos-iov deleted the feature/adding_repo_owner_input branch October 10, 2024 13:02
@Vovchyk Vovchyk restored the feature/adding_repo_owner_input branch October 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcos-iov marcos-iov marcos-iov approved these changes

@Vovchyk Vovchyk Vovchyk approved these changes

@fmacleal fmacleal fmacleal left review comments

@jeremy-then jeremy-then jeremy-then left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rmoreliovlabs @Vovchyk @marcos-iov @jeremy-then @fmacleal