Refactors federation and bridge balances checks and pegin btc event. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marcos-iov
approved these changes
Sep 26, 2024
marcos-iov
merged commit a7a0fd4
into
rits-refactors-9-2024-integration
4 checks passed
marcos-iov
deleted the
refactor-federation-and-bridge-balances-check
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the assertions of the federation and bridge balances to an utility function
assert2wpBalancesAfterSuccessfulPeginto reuse it and reduce complexity.Takes the assertion of the expected pegin btc to an utility function
assertExpectedPeginBtcEventIsEmitted.Left these functions in the 2wp.js file since they make sense here and all pegins tests will be here.
Also adds a new
get2wpBalancesfunction in2wp-utils.jsfile, to get the federation, bridge utxos and bridge rsk balances.