Using BN for all weis

rsksmart · Sep 26, 2024 · a7e1868 · a7e1868
1 parent 74e64d5
commit a7e1868
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/tests/2wp.js b/lib/tests/2wp.js
@@ -25,7 +25,7 @@ let minimumPeginValueInBtc;
 let btcFeeInSatoshis;
 
 const get2wpInitialBalances = async () => {
-  const initialBridgeBalanceInWeisBN = Number(await rskTxHelper.getBalance(BRIDGE_ADDRESS));
+  const initialBridgeBalanceInWeisBN = await rskTxHelper.getBalance(BRIDGE_ADDRESS);
   const initialBridgeUtxosBalanceInSatoshis = await getBridgeUtxosBalance(rskTxHelper);
   const initialFederationAddressBalanceInSatoshis = await getBtcAddressBalanceInSatoshis(btcTxHelper, federationAddress);
   return {
@@ -45,15 +45,17 @@ const assertExpectedPeginBtcEventIsEmitted = async (btcPeginTxHash, rskRecipient
 
 const assertSuccessfulPegin2wpFinalBalances = async (initial2wpBalances, peginValueInSatoshis) => {
 
-  const { initialBridgeBalanceInWeisBN, initialBridgeUtxosBalanceInSatoshis, initialFederationAddressBalanceInSatoshis } = initial2wpBalances
+  const { initialBridgeBalanceInWeisBN, initialBridgeUtxosBalanceInSatoshis, initialFederationAddressBalanceInSatoshis } = initial2wpBalances;
 
   // The federation balance is increased by the pegin value
   const finalFederationAddressBalanceInSatoshis = await getBtcAddressBalanceInSatoshis(btcTxHelper, federationAddress);
   expect(finalFederationAddressBalanceInSatoshis).to.be.equal(initialFederationAddressBalanceInSatoshis + peginValueInSatoshis);
 
   // After the successful pegin, the Bridge balance should be reduced by the pegin value
-  const finalBridgeBalance = Number(await rskTxHelper.getBalance(BRIDGE_ADDRESS));
-  expect(finalBridgeBalance).to.be.equal(initialBridgeBalanceInWeisBN - satoshisToWeis(peginValueInSatoshis));
+  const finalBridgeBalanceInWeisBN = await rskTxHelper.getBalance(BRIDGE_ADDRESS);
+  const peginValueInWeisBN = rskTxHelper.getClient().utils.BN(satoshisToWeis(peginValueInSatoshis));
+  const expectedFinalBridgeBalancesInWeisBN = initialBridgeBalanceInWeisBN.sub(peginValueInWeisBN);
+  expect(finalBridgeBalanceInWeisBN.eq(expectedFinalBridgeBalancesInWeisBN)).to.be.true;
 
   // After the successful pegin, the Bridge utxos sum should be incremented by the pegin value
   const finalBridgeUtxosBalance = await getBridgeUtxosBalance(rskTxHelper);