Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default socketTimeout value to 30 seconds #380

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Update default socketTimeout value to 30 seconds #380

merged 1 commit into from
Jan 17, 2025

Conversation

marcos-iov
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@marcos-iov marcos-iov requested a review from a team as a code owner January 17, 2025 14:41
@github-actions GitHub Actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

jeremy-then
jeremy-then approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

@marcos-iov marcos-iov merged commit 3575588 into master Jan 17, 2025
12 checks passed
@marcos-iov marcos-iov deleted the socket-tmieout-update branch January 17, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanieliov nathanieliov nathanieliov approved these changes

@jeremy-then jeremy-then jeremy-then approved these changes

@julia-zack julia-zack julia-zack approved these changes

@apancorb apancorb apancorb approved these changes

@julianlen julianlen julianlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcos-iov @julianlen @apancorb @julia-zack @jeremy-then @nathanieliov