Feature/powpeg validation protocol integration#374

Merged

marcos-iov merged 112 commits intomasterfrom feature/powpeg_validation_protocol-integration

Jan 24, 2025

+2,253-1,145

Commits on Jan 24, 2025

refactor(fed): federation watcher tests

apancorb
authored and
marcos-iov
committed
feat(federate): change access modifier for federation watcher listerner

apancorb
authored and
marcos-iov
committed
fix(btcreleaseclient): remove signature cache dependency from BridgeEventLoggerImpl in tests

apancorb
authored and
marcos-iov
committed
feat(federate): implement getProposedFederationAddress in federation support

apancorb
authored and
marcos-iov
committed
feat(bitcoin): add bitcoin test util methods

apancorb
authored and
marcos-iov
committed
refactor(watcher): refactor federation watcher to its own package

apancorb
authored and
marcos-iov
committed
refactor(watcher): simplify FederationWatcherListener interface and avoid using Optional as parameters

apancorb
authored and
marcos-iov
committed
refactor(watcher): organize and remove some comments for FederationWatcher

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): federator should be part of the federation when starting

apancorb
authored and
marcos-iov
committed
feat(federate): throw an exception if federator is not a member of the federation when starting

apancorb
authored and
marcos-iov
committed
feat(watcher): change stop and starting logic when active and retiring federation

apancorb
authored and
marcos-iov
committed
refactor(watcher): rename interface variables to be more explicit and avoid confusion

apancorb
authored and
marcos-iov
committed
fix(federate): solve unit tests since was using a member not part of the federation

apancorb
authored and
marcos-iov
committed
refactor(watcher): change updateActiveFederation to use the original implementation without Optional

apancorb
authored and
marcos-iov
committed
refactor(watcher): small code structure change and better logging

apancorb
authored and
marcos-iov
committed
feat(watcher): make the active federation be required to be non-null

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): make better log statements for start and stop client methods

apancorb
authored and
marcos-iov
committed
fix(btcreleaseclient): if the member running the node is not part of the new federation should throw exception

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add unit test for federation member is not part of new federationa and fix the rest of exisiting tests to accomdate new condition

apancorb
authored and
marcos-iov
committed
feat(watcher): add unit tests for FederationWatcherListenerImpl

apancorb
authored and
marcos-iov
committed
feat(config): add description for isPegoutEnabled parameter

apancorb
authored and
marcos-iov
committed
refactor(federate): remove unused method getLiveFederations

apancorb
authored and
marcos-iov
committed
refactor(federate): remove unused unit tests for getLiveFederations method

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): enhance javadoc for class

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): small refactor to include proper spaces and identation

apancorb
authored and
marcos-iov
committed
feat(federate): add bridge call to retrieve svp spend tx waiting for signatures

apancorb
authored and
marcos-iov
committed
refactor(federate): remove unnecessary blank lines in FederateSupport class

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add call to getStateForProposedFederator when processing a best block and add precondition method isReadyToBeSigned

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): small change to code structure for rsk tx wfs stream

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add unit tests for svp tx waiting for signatures and pegout is not ready to be signed

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): reword svp spend comment

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): propper code formatting

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add receipt store logic to find the block hash for each rsk tx waiting for signatures

apancorb
authored and
marcos-iov
committed
feat(federate): add receipt store dependency to BtcReleaseClient class

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add confirmation diff logic using the receipt store for unit tests

apancorb
authored and
marcos-iov
committed
fix(btcreleaseclient): avoid shadowing receipt store instance variable

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): include is ready to sign method only for the svp spend tx

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): update log statement

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): use mainnet params for unit tests

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add better naming for unit tests vars

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add both svp spend tx and pegout unit test and simplify svp spend ready to sign testing logic

apancorb
authored and
marcos-iov
committed
refactor(btcreleaseclient): reuse fed key for unit test

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient) add unit test for when pegouts and svp spend tx are available but federator is only part of proposed

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): update all fed ekys for unit tests

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): add warning log in case isPegoutEnabled is disabled in config

apancorb
authored and
marcos-iov
committed
feat(federate): add unit tests for getStateForProposedFederator

apancorb
authored and
marcos-iov
committed
feat(btcreleaseclient): use ReleaseCreationInformationGetter to retrieve block data about the svp spend tx

apancorb
authored and
marcos-iov
committed
feat(federate): add getProposedFederationSize to FederatorSupport

apancorb
authored and
marcos-iov
committed
feat(federate): add getProposedFederatorPublicKeyOfType to FederatorSupport

apancorb
authored and
marcos-iov
committed
feat(federate): add getProposedFederationCreationTime to FederatorSupport

apancorb
authored and
marcos-iov
committed
feat(federate): add getProposedFederationCreationBlockNumber to FederatorSupport

apancorb
authored and
marcos-iov
committed
feat(federate): add getProposedFederation to FederationProvider interface

apancorb
authored and
marcos-iov
committed
feat(federate): add implementation of getProposedFederation to FederationProviderFromFederatorSupport

apancorb
authored and
marcos-iov
committed
refactor(federate): use FEDERATION_NON_EXISTENT enum code in conditional check for building retiring federation

apancorb
authored and
marcos-iov
committed
feat(federate): add unit tests for getProposedFederationSize

apancorb
authored and
marcos-iov
committed
feat(federate): add unit tests for getProposedFederatorPublicKeyOfType

apancorb
authored and
marcos-iov
committed
feat(federate): add unit tests for getProposedFederationCreationTime

apancorb
authored and
marcos-iov
committed
feat(federate): add unit tests for getProposedFederationCreationBlockNumber

apancorb
authored and
marcos-iov
committed
feat(federate): add unit tests for getProposedFederation

apancorb
authored and
marcos-iov
committed
fix(federate): use proper activation rule for svp

apancorb
authored and
marcos-iov
committed
refactor(federate): improve javadocs for FederationProvider interface

apancorb
authored and
marcos-iov
committed
refactor(federate): use isEmpty when checking if retiring federation exists

apancorb
authored and
marcos-iov
committed
feat(federate): throw exception if after proving that the proposed federation exists any related data is missing

apancorb
authored and
marcos-iov
committed
refactor(federate): method call consistent with all the other proposed ones

apancorb
authored and
marcos-iov
committed
feat(federate): after rskip419 the only possible type of federation is a P2shErpFederation

apancorb
authored and
marcos-iov
committed
feat(federate): remove unit tests for proposed federation that are unrealistic

apancorb
authored and
marcos-iov
committed
fix(federate): update var name to not shadow global federator support var

apancorb
authored and
marcos-iov
committed
refactor(federate): replace lambda with method reference 'IllegalStateException::new'

apancorb
authored and
marcos-iov
committed
refactor(federate): improve sonar complaints of FederateSupport

apancorb
authored and
marcos-iov
committed
refactor(federate): make FederationProvider javadoc more concise

apancorb
authored and
marcos-iov
committed
feat(federate): remove checking the proposed federation addr to validate exisiting fed

apancorb
authored and
marcos-iov
committed
feat(federate): remove unit tests verifying if proposed fed addr is being called to check if proposed fed exists

apancorb
authored and
marcos-iov
committed
feat(federate): add try-catch block in case proposed federation is unable to be built

apancorb
authored and
marcos-iov
committed
feat(federate): add unit test when proposed federation cannot be built because some data is missing from the Bridge

apancorb
authored and
marcos-iov
committed
refactor(federate): rename unit tests

apancorb
authored and
marcos-iov
committed
refactor(federate): use ECKey class to build pub key in unit tests

apancorb
authored and
marcos-iov
committed
feat(federate): change catch exception class to catch all possible exception while building the proposed federation

apancorb
authored and
marcos-iov
committed
refactor(federate): remove checking if RSKIP419 is activated for proposed federation

apancorb
authored and
marcos-iov
committed
feat(federate): remove RSKIP419 reference for unit tests

apancorb
authored and
marcos-iov
committed
feat(federate): remove unit tests related with proposed fed and rskip419

apancorb
authored and
marcos-iov
committed
refactor(federate): remove Optional flat map to get the addr of the proposed fed

apancorb
authored and
marcos-iov
committed
feat(federate): remove unnecessary use of mocking activations in unit tests

apancorb
authored and
marcos-iov
committed
refactor(federate): removed checking if retiring fed addr is present when building retiring fed

apancorb
authored and
marcos-iov
committed
feat(federate): Change getProposedFederationCreationTime to return Instant based on seconds

apancorb
authored and
marcos-iov
committed
feat(federate): wrap logic for building the retiring fed in try-catch

apancorb
authored and
marcos-iov
committed
refactor(federate): enhance javadoc for FederationProviderFromFederatorSupport class

apancorb
authored and
marcos-iov
committed
feat(federate): add unit test when getting addr for retiring fed does not exist

apancorb
authored and
marcos-iov
committed
feat(federate): allow exception to propagate in the listener if unable to build federation after validating the federation size

apancorb
authored and
marcos-iov
committed
feat(watcher): add onProposedFederation method to interface

apancorb
authored and
marcos-iov
committed
feat(watcher): intial implementation of onProposedFederationChange

apancorb
authored and
marcos-iov
committed
feat(watcher): enhance with try-catch and logging onProposedFederationChange

apancorb
authored and
marcos-iov
committed
feat(watcher): use javadoc annotation for comment in onProposedFederationChange

apancorb
authored and
marcos-iov
committed
feat(watcher): add unit tests for onProposedFederationChange

apancorb
authored and
marcos-iov
committed
feat(watcher): implement onProposedFederationChange for anoymous classes in FederationWatcherTest

apancorb
authored and
marcos-iov
committed
feat(watcher): add logic for change in proposed fed in FederationWatcher class

apancorb
authored and
marcos-iov
committed
refactor(watcher): use mock of federation watcher listener instead of implementing an anoymous class per test

apancorb
authored and
marcos-iov
committed
feat(watcher): accomdate existing unit tests for proposed fed logic

apancorb
authored and
marcos-iov
committed
feat(watcher): call updateProposedFederation before updateActiveFederation to follow chrono order

apancorb
authored and
marcos-iov
committed
feat(watcher): add unit test for proposed federation in FederationWatcherTest class

apancorb
authored and
marcos-iov
committed
refactor(wathcer): log statement for onProposedFederationChange

apancorb
authored and
marcos-iov
committed
refactor(watcher): test naming and log statements

apancorb
authored and
marcos-iov
committed
fix(federate): add RSKIP419 check for proposed federation methods

apancorb
authored and
marcos-iov
committed
Adapt to time unit bridge method change

julia-zack
authored and
marcos-iov
committed
Add tests pre rskip 419

julia-zack
authored and
marcos-iov
committed
fix(btcreleaseclient): place call to get svp spend tx wfs behind activation check

apancorb
authored and
marcos-iov
committed
fix(watcher): add correct log prefix

apancorb
authored and
marcos-iov
committed
feat(bitcoin): add logic to detect when processing a svp spend tx

apancorb
authored and
marcos-iov
committed
refactor(federate): add proper spacing between code segments

apancorb
authored and
marcos-iov
committed
refactor(federate): move code segments in BtcToRskClient

apancorb
authored and
marcos-iov
committed
feat(bitcoin): remove svp spend tx handling in BitcoinWrapperImpl

apancorb
authored and
marcos-iov
committed
feat(watcher): add BitcoinWrapper to onProposedFederationChange so it can register the svp spend tx

apancorb
authored and
marcos-iov
committed
feat(watcher): update unit tests to accomdate BitcoinWrapper listener logic to register svp spend tx

apancorb
authored and
marcos-iov
committed