Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extend orm client #8

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

jonkan81
Copy link
Contributor

@jonkan81 jonkan81 commented Dec 4, 2023

Adds:

  • Parametrized ORM queries
  • Parametrized execute statements
  • Interfaces for RqliteClient and RqliteOrmClient useful for dependency injection, unit testing etc.

@SebastianThorn SebastianThorn deleted the feature/extend_orm_client branch December 4, 2023 14:48
@otoolep
Copy link
Member

otoolep commented Dec 4, 2023

@arthrp -- would you review this, and merge if it looks good to you?

@otoolep
Copy link
Member

otoolep commented Dec 4, 2023

Thanks for your contribution, @jonkan81

@jonkan81 jonkan81 restored the feature/extend_orm_client branch December 4, 2023 15:00
@otoolep otoolep requested a review from arthrp December 5, 2023 01:18
@otoolep
Copy link
Member

otoolep commented Dec 5, 2023

Say we want to enable continuous testing, what's a good environment? Something on CircleCI?

@arthrp
Copy link
Collaborator

arthrp commented Oct 27, 2024

@otoolep
Sorry, due to personal issues I'm not too active here. For CI the easiest option is Github actions

@arthrp
Copy link
Collaborator

arthrp commented Oct 28, 2024

@SjoVJonatan Thanks for your contribution! There're still few outstanding minor issues but I think we can merge now

@arthrp arthrp merged commit d7b5009 into rqlite:main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants