Add an assertion check in readAll

If the assertion could fail somehow, we could have memory unsafety.
rprichard · Jan 4, 2017 · 9f0d7e6 · 9f0d7e6
1 parent 91fce49
commit 9f0d7e6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/libwinpty/winpty.cc b/src/libwinpty/winpty.cc
@@ -342,7 +342,8 @@ static size_t readData(winpty_t &wp, void *data, size_t amount) {
 
 static void readAll(winpty_t &wp, void *data, size_t amount) {
     while (amount > 0) {
-        size_t chunk = readData(wp, data, amount);
+        const size_t chunk = readData(wp, data, amount);
+        ASSERT(chunk <= amount && "readData result is larger than amount");
         data = reinterpret_cast<char*>(data) + chunk;
         amount -= chunk;
     }