-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics to track metadata_json_download success and failure #207
Merged
kespinola
merged 3 commits into
grpc-ingest
from
das-99-export-status-code-of-download_metadata_json-response-to
Jan 21, 2025
Merged
Add metrics to track metadata_json_download success and failure #207
kespinola
merged 3 commits into
grpc-ingest
from
das-99-export-status-code-of-download_metadata_json-response-to
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespinola
requested changes
Jan 14, 2025
kespinola
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the metric name change but looks good. Thank you.
Nagaprasadvr
force-pushed
the
das-99-export-status-code-of-download_metadata_json-response-to
branch
from
January 15, 2025 08:04
cd2c816
to
d3c1752
Compare
kespinola
requested changes
Jan 15, 2025
Nagaprasadvr
force-pushed
the
das-99-export-status-code-of-download_metadata_json-response-to
branch
from
January 15, 2025 11:50
fab4511
to
53a7898
Compare
kespinola
requested changes
Jan 15, 2025
Nagaprasadvr
force-pushed
the
das-99-export-status-code-of-download_metadata_json-response-to
branch
3 times, most recently
from
January 15, 2025 13:29
1b12b68
to
9a28def
Compare
kespinola
requested changes
Jan 16, 2025
Nagaprasadvr
force-pushed
the
das-99-export-status-code-of-download_metadata_json-response-to
branch
from
January 17, 2025 06:41
70ef4bf
to
8618fe8
Compare
kespinola
reviewed
Jan 21, 2025
kespinola
force-pushed
the
das-99-export-status-code-of-download_metadata_json-response-to
branch
from
January 21, 2025 10:30
8618fe8
to
548e123
Compare
kespinola
approved these changes
Jan 21, 2025
kespinola
deleted the
das-99-export-status-code-of-download_metadata_json-response-to
branch
January 21, 2025 10:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics to track metadata json download