Bug fix and patch-version bump (#4)

* bump version to 1.1.0

* fix and test for multiple prop fails on one component

* don't handle high counts at all for now, and bump to v1.1.1

lib/rules/default-props-prefer-undefined.js

@@ -156,7 +156,7 @@ module.exports = {
 
       for (
         let i = 0, len = expectations.length;
-        errorMessageId === undefined, i < len; // break the loop on first issue found
+        errorMessageId === undefined && i < len; // break the loop on first issue found
         i += 1
       ) {
         const { value, isOn } = expectations[i];

lib/rules/exports-newlines.js

@@ -94,9 +94,8 @@ module.exports = {
       const lineDifference = getLineDifference(node, nextNode);
 
       const countIsLow = lineDifference < EXPECTED_LINE_DIFFERENCE;
-      const countIsHigh = lineDifference > EXPECTED_LINE_DIFFERENCE;
 
-      if (countIsLow || countIsHigh) {
+      if (countIsLow) {
         let column = node.loc.start.column;
 
         if (node.loc.start.line !== node.loc.end.line) {

lib/tests/rules/default-props-prefer-undefined.js

@@ -17,6 +17,8 @@ const rule = require('../../rules/default-props-prefer-undefined');
 
 const ERR_MSG_EXPECTED_NOT_NULL = 'Expected default prop someProp to be undefined but is null';
 const ERR_MSG_EXPECTED_NOT_FALSE = 'Expected default prop someProp to be undefined but is false';
+const ERR_MSG_MULTI_EXPECTED_NOT_NULL = 'Expected default prop anotherProp to be undefined but is null';
+const ERR_MSG_MULTI_EXPECTED_NOT_FALSE = 'Expected default prop otherProp to be undefined but is false';
 
 //------------------------------------------------------------------------------
 // Tests
@@ -489,5 +491,41 @@ errors: [{
         message: ERR_MSG_EXPECTED_NOT_FALSE,
       }],
     },
+    // check that every default prop with issue fires a report
+    {
+      code: `
+        const SomeComponent = (props) => {
+          return <div />;
+        };
+        SomeComponent.propTypes = {
+          someProp: PropTypes.string,
+          otherProp: PropTypes.bool,
+          anotherProp: PropTypes.number,
+          lastProp: PropTypes.shape({}),
+        };
+        SomeComponent.defaultProps = {
+          someProp: null,
+          otherProp: false,
+          anotherProp: null,
+          lastProp: undefined,
+        };
+      `,
+      options: [{
+        forbidFalse: true,
+      }],
+      errors: [{
+        line: 12,
+        column: 11,
+        message: ERR_MSG_EXPECTED_NOT_NULL,
+      }, {
+        line: 13,
+        column: 11,
+        message: ERR_MSG_MULTI_EXPECTED_NOT_FALSE,
+      }, {
+        line: 14,
+        column: 11,
+        message: ERR_MSG_MULTI_EXPECTED_NOT_NULL,
+      }],
+    },
   ],
 });

lib/typedefs.js

@@ -8,6 +8,7 @@
  * @property {*[]} decorators
  * @property {Object} loc
  * @property {ASTNode} parent
+ * @property {number[]} range
  * @property {string} type
  * @property {ASTNode|BuiltInType} value
  */

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-routable",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Internal ESLint plugin for Routable",
   "keywords": [
     "eslint",