fix: don't need to rename, can use contains instead

rostools · Mar 15, 2024 · c4957d8 · c4957d8
1 parent 455add8
commit c4957d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/R/create-teams.R b/R/create-teams.R
@@ -111,7 +111,7 @@ assign_learners_to_groups <- function(data, group_names, score_cutoff = 3) {
   data %>%
     dplyr::select(
       full_name,
-      tidyselect::any_of("github_username"),
+      tidyselect::contains("github"),
       tidyselect::matches("^perceived")
     ) %>%
     dplyr::rowwise() %>%
@@ -124,7 +124,7 @@ assign_learners_to_groups <- function(data, group_names, score_cutoff = 3) {
     dplyr::select(
       team,
       full_name,
-      tidyselect::any_of("github_username"),
+      tidyselect::contains("github"),
       perceived_skill_score
     ) %>%
     dplyr::arrange(team, perceived_skill_score)

diff --git a/R/get-precourse-survey.R b/R/get-precourse-survey.R
@@ -51,18 +51,12 @@ tidy_precourse <- function(data, metadata_dates) {
       ~ purrr::map_chr(.x, as.character)
     )) |>
     dplyr::rename_with(snakecase::to_snake_case) |>
-    dplyr::rename(github_username = what_is_your_git_hub_user_name,
-                  email = email_address) |>
     dplyr::mutate(
       course_version = assign_course_version_by_date(timestamp, metadata_dates)
     ) |>
     dplyr::mutate(dplyr::across(
       tidyselect::contains("_perceive_your_skill_"),
       tidy_cols_skills
-    )) |>
-    dplyr::mutate(dplyr::across(
-      tidyselect::matches("^github_username$"),
-      ~ stringr::str_remove(.x, pattern = "\\@")
     ))
 }