Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 🎨 set course title and subtitle #57

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

signekb
Copy link
Member

@signekb signekb commented Nov 6, 2024

Description

This PR adds the course title and subtitle in the _quarto.yml.

Initially, I added the title and subtitle we agreed on in #55 and #40 , but I kept brainstorming a bit and found an alternative that I liked more; it's simpler/shorter and more digestible, in my opinion.

There's just something that I don't quite like about "collaborating as a team" + we're missing the s from the abbreviation. And I liked the explicit addition of the "CATs" abbreviation in the title too.
With the subtitle "An introduction to ...", I think that we still incorporate the "you don't have to be collaborative team just yet, but wanting to learn it is enough"-part that we talked about earlier.

Buuutttt, if you don't like it, I can just revert it 🐱 🐈

Closes #55
Closes #40
Related to #20

Reviewer Focus

This PR needs an in-depth review.

Checklist

  • Rendered website locally

@signekb signekb requested a review from a team as a code owner November 6, 2024 12:08
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its mostly fine for the short title to say that. Here are some comments.

_quarto.yml Outdated Show resolved Hide resolved
_quarto.yml Outdated Show resolved Hide resolved
@signekb signekb requested a review from lwjohnst86 November 6, 2024 14:30
@lwjohnst86 lwjohnst86 merged commit 1c56bb5 into main Nov 6, 2024
@lwjohnst86 lwjohnst86 deleted the docs/set-course-title-and-subtitle branch November 6, 2024 14:41
lwjohnst86 added a commit that referenced this pull request Nov 8, 2024
## Description

These changes are to align the title and subtitle in the `README` with
what we have agreed on in #40 and implemented in #57 .

While I was at it, I added a licence badge as well.

## Reviewer Focus

This PR needs a quick review. 

## Checklist

- [X] Ran spell-check
- [X] Rendered website locally

---------

Co-authored-by: Luke W. Johnston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update repo name and course names Brainstorm the course title
2 participants