Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Zenoh version #405

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

YuanYuYuan
Copy link
Contributor

This version includes the following fixes:

  • Fix memory leak in string deserialization (zenoh-cpp#363)
  • Fix SHM Garbage Collection (GC) policy (zenoh#1696)
  • Fix deadlock in advanced subscription undeclaration (zenoh#1685)

This version includes the following fixes:
- Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363))
- Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696))
- Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add comments above the ament_vendor calls to highlight the fixes we include with the commit?

Also please run the usual tests and report any issues!

@YuanYuYuan
Copy link
Contributor Author

Test Result

@YuanYuYuan
Copy link
Contributor Author

The bugfixes have been added to the CMakefile. @Yadunund can you review this? Thanks.

@ahcorde ahcorde merged commit 1f2d675 into ros2:rolling Jan 10, 2025
5 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Jan 10, 2025

https://github.com/Mergifyio backport jazzy humble

Copy link

mergify bot commented Jan 10, 2025

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 10, 2025
This version includes the following fixes:
- Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363))
- Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696))
- Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))

(cherry picked from commit 1f2d675)
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
This version includes the following fixes:
- Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363))
- Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696))
- Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))

(cherry picked from commit 1f2d675)
ahcorde pushed a commit that referenced this pull request Jan 10, 2025
This version includes the following fixes:
- Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363))
- Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696))
- Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))

(cherry picked from commit 1f2d675)

Co-authored-by: Yuyuan Yuan <[email protected]>
ahcorde pushed a commit that referenced this pull request Jan 10, 2025
This version includes the following fixes:
- Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363))
- Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696))
- Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))

(cherry picked from commit 1f2d675)

Co-authored-by: Yuyuan Yuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants