fix(Executor): Fixed entities not beeing executed after just beeing added #2724
Conversation
|
CI
|
There was a problem hiding this comment.
lgtm, but one question
Is it important for just_waited to be set to false as we are doing, or could we just change the one place it is read to be if (!entities_need_rebuild_ && just_waited) {? From a purely semantic point of view, setting just_waited = false is kind not "true" because we did actually just wait, we just have another condition to consider now, which is what lead me to wonder why we don't just change the condition logic where we check for whether we just waited or not (line 401).
|
I agree the name just_waited is now odd, I'll try to adopt it a bit... |
|
@jmachowinski have you had a chance to work on the review comments? ❤️ |
Friday is my "Ros Day". I would still need a confirmation that this really fixes your bug though... |
…dded Fixes ros2#2589 Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
force-pushed
the
double_spin
branch
from
439e51c to
c44f1ec
Compare
|
@wjwwood I renamed the just_wait bool to entity_states_fully_polled, so that the semantic should be clearer now. |
|
Pulls: #2724
|
|
I would say the windows tests are unrelated, as they are mypy something. |
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
…dded (#2724) Fixes #2589 Signed-off-by: Janosch Machowinski <[email protected]> Co-authored-by: Janosch Machowinski <[email protected]> (cherry picked from commit e7afaa6)
Fixes #2589