Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding adi_tmc_coe to documentation index for distro #42126

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

CAcarADI
Copy link
Contributor

@CAcarADI CAcarADI commented Jul 18, 2024

Please Add This Package to be indexed in the rosdistro.

adi_tmc_coe

The source is here:

https://github.com/analogdevicesinc/adi_tmc_coe

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the noetic Issue/PR is for the ROS 1 Noetic distribution label Jul 18, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the change inline, this also needs to be rebased due to some unrelated changes in this area of the file.

noetic/distribution.yaml Outdated Show resolved Hide resolved
@CAcarADI
Copy link
Contributor Author

Hi @clalancette , Ive already pushed the suggested commit and rebased the commit but the Merging is blocked, is there anything I need to do to fix this?

@CAcarADI CAcarADI requested a review from clalancette July 26, 2024 14:27
@clalancette
Copy link
Contributor

New package review checklist

@clalancette clalancette merged commit 439c287 into ros:master Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noetic Issue/PR is for the ROS 1 Noetic distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants