-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python-ifaddr
#39511
Add python-ifaddr
#39511
Conversation
Needed in ros2/ros2cli#875
@@ -1941,6 +1941,13 @@ python-hypothesis: | |||
gentoo: [dev-python/hypothesis] | |||
ubuntu: | |||
'*': [python-hypothesis] | |||
python-ifaddr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cottsay do you know why it would be suggesting python2-ifaddr
for opensuse when the package URL itself is python-ifaddr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python2-ifaddr
RPM package provides a virtual package called python-ifaddr
:
$ rpm --qf '[%{PROVIDES}\n]' -qp https://download.opensuse.org/distribution/leap/15.2/repo/oss/noarch/python2-ifaddr-0.1.6-lp152.2.1.noarch.rpm
python-ifaddr
python2-ifaddr
In Fedora, it was normal for Python packages to provide the "unversioned" python package name to ease the transition away from the unversioned package names. Evidently openSUSE did the same thing.
Two notes here:
- We should update our openSUSE Leap version target to 15.5, where the Python 2 packages are no longer available so warnings like this won't show up.
- Why is the key
python-ifaddr
and notpython3-ifaddr
? Shouldn't new keys follow the Ubuntu package name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-ifaddr: | |
python3-ifaddr: |
For new python keys they should be python3-*
to match the key values which all appear to be python 3.
Note that this will require it to be re-alphabetized too. And should avoid the opensuse python2 question above too.
@@ -1941,6 +1941,13 @@ python-hypothesis: | |||
gentoo: [dev-python/hypothesis] | |||
ubuntu: | |||
'*': [python-hypothesis] | |||
python-ifaddr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python2-ifaddr
RPM package provides a virtual package called python-ifaddr
:
$ rpm --qf '[%{PROVIDES}\n]' -qp https://download.opensuse.org/distribution/leap/15.2/repo/oss/noarch/python2-ifaddr-0.1.6-lp152.2.1.noarch.rpm
python-ifaddr
python2-ifaddr
In Fedora, it was normal for Python packages to provide the "unversioned" python package name to ease the transition away from the unversioned package names. Evidently openSUSE did the same thing.
Two notes here:
- We should update our openSUSE Leap version target to 15.5, where the Python 2 packages are no longer available so warnings like this won't show up.
- Why is the key
python-ifaddr
and notpython3-ifaddr
? Shouldn't new keys follow the Ubuntu package name?
ubuntu: | ||
'*': [python3-ifaddr] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be simplified:
ubuntu: | |
'*': [python3-ifaddr] | |
ubuntu: [python3-ifaddr] |
@@ -1941,6 +1941,13 @@ python-hypothesis: | |||
gentoo: [dev-python/hypothesis] | |||
ubuntu: | |||
'*': [python-hypothesis] | |||
python-ifaddr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-ifaddr: | |
python3-ifaddr: |
For new python keys they should be python3-*
to match the key values which all appear to be python 3.
Note that this will require it to be re-alphabetized too. And should avoid the opensuse python2 question above too.
@lalten friendly ping. |
Thanks for the ping. I originally needed ifaddr for ros2/ros2cli#875, but that PR ended up using |
Please add
python-ifaddr
to the rosdep database.Needed in ros2/ros2cli#875
Package name:
python-ifaddr
Package Upstream Source:
https://github.com/pydron/ifaddr
Purpose of using this:
python-netifaces
(https://github.com/al45tair/netifaces) is unmaintained: al45tair/netifaces#78. ifaddr is an alternative.Distro packaging links:
Links to Distribution Packages