-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily rolling back jazzy 4.2.0-1 update due to downstream issues. #387
Comments
Hi @marcoag. Could you please help me identify one failed run of the downstream jobs. I looked through almost all of them and could not identify one that failed due to diagnostic_updater |
Sorry, I didn't realized that after the rollback the downstream jobs would show up as successful and hard to find. Let me point some of them out: https://build.ros2.org/view/Jbin_uN64/job/Jbin_uN64__swri_roscpp__ubuntu_noble_amd64__binary/24/consoleFull The error show up like this:
Thanks for having a look btw. |
I see. This is most likely caused by #331. Without looking too deep into it. Unfortunately I am in the last hours before one week of vacations right now. If I don't find the time to do this over the weekend I can only look into it after July 30. Just FYI. |
@Rayman could you please have a look at this if you have time. Most likely this just misses an include in the right place. |
Without this, downstream packages have missing symbols Relates to: ros#387
I've created a fix for the missing symbols: #388 The To be honest, I'm a bit confused by the branches. It seems that |
Without this, downstream packages have missing symbols Relates to: #387
And I fixed that. There were some features not properly backported. But in the future, please make all PRs against |
Without this, downstream packages have missing symbols Relates to: #387 (cherry picked from commit d8fef69) Co-authored-by: Ramon Wijnands <[email protected]>
If you have any more build failure, feel free to ping me |
see ros/rosdistro#42285 for the release |
@ct2034 I will temporarily roll back your latest rosdistro pr for jazzy: ros/rosdistro#41859 due to a bunch downstream issues with the
diagnostic_updater
that are creating several jazzy regressions.You can see failing "Downstream Projects" in:
https://build.ros2.org/view/Jbin_uN64/job/Jbin_uN64__diagnostic_updater__ubuntu_noble_amd64__binary/
It looks like some symbols might be missing from the binaries so it would be great if you can take a look at this. Feel free to send an update PR anytime.
The text was updated successfully, but these errors were encountered: