Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily rolling back jazzy 4.2.0-1 update due to downstream issues. #387

Closed
marcoag opened this issue Jul 18, 2024 · 9 comments
Closed

Comments

@marcoag
Copy link

marcoag commented Jul 18, 2024

@ct2034 I will temporarily roll back your latest rosdistro pr for jazzy: ros/rosdistro#41859 due to a bunch downstream issues with the diagnostic_updater that are creating several jazzy regressions.

You can see failing "Downstream Projects" in:

https://build.ros2.org/view/Jbin_uN64/job/Jbin_uN64__diagnostic_updater__ubuntu_noble_amd64__binary/

It looks like some symbols might be missing from the binaries so it would be great if you can take a look at this. Feel free to send an update PR anytime.

@ct2034
Copy link
Collaborator

ct2034 commented Jul 18, 2024

Hi @marcoag. Could you please help me identify one failed run of the downstream jobs. I looked through almost all of them and could not identify one that failed due to diagnostic_updater

@marcoag
Copy link
Author

marcoag commented Jul 19, 2024

Sorry, I didn't realized that after the rollback the downstream jobs would show up as successful and hard to find. Let me point some of them out:

https://build.ros2.org/view/Jbin_uN64/job/Jbin_uN64__swri_roscpp__ubuntu_noble_amd64__binary/24/consoleFull
https://build.ros2.org/view/Jbin_uN64/job/Jbin_uN64__swri_roscpp__ubuntu_noble_amd64__binary/24/consoleFull

The error show up like this:

/opt/ros/jazzy/include/diagnostic_updater/diagnostic_updater.hpp:378:(.text+0x6633): undefined reference to `diagnostic_updater::Updater::Updater(std::shared_ptr<rclcpp::node_interfaces::NodeBaseInterface>, std::shared_ptr<rclcpp::node_interfaces::NodeClockInterface>, std::shared_ptr<rclcpp::node_interfaces::NodeLoggingInterface>, std::shared_ptr<rclcpp::node_interfaces::NodeParametersInterface>, std::shared_ptr<rclcpp::node_interfaces::NodeTimersInterface>, std::shared_ptr<rclcpp::node_interfaces::NodeTopicsInterface>, double)'

Thanks for having a look btw.

@ct2034
Copy link
Collaborator

ct2034 commented Jul 19, 2024

I see. This is most likely caused by #331. Without looking too deep into it.

Unfortunately I am in the last hours before one week of vacations right now. If I don't find the time to do this over the weekend I can only look into it after July 30. Just FYI.

@ct2034
Copy link
Collaborator

ct2034 commented Jul 19, 2024

@Rayman could you please have a look at this if you have time. Most likely this just misses an include in the right place.

Rayman added a commit to nobleo/diagnostics that referenced this issue Jul 22, 2024
Without this, downstream packages have missing symbols

Relates to: ros#387
@Rayman
Copy link
Contributor

Rayman commented Jul 22, 2024

I've created a fix for the missing symbols: #388

The swri_roscpp package actually has another bug: swri-robotics/marti_common#742

To be honest, I'm a bit confused by the branches. It seems that ros2 is behind ros2-jazzy.

ct2034 pushed a commit that referenced this issue Jul 22, 2024
Without this, downstream packages have missing symbols

Relates to: #387
ct2034 pushed a commit to ct2034/diagnostics that referenced this issue Jul 22, 2024
Without this, downstream packages have missing symbols

Relates to: ros#387

(cherry picked from commit d8fef69)
@ct2034
Copy link
Collaborator

ct2034 commented Jul 30, 2024

@Rayman But, could you verify that #388 solved at least the above-mentioned linker problem?

@ct2034
Copy link
Collaborator

ct2034 commented Jul 30, 2024

To be honest, I'm a bit confused by the branches. It seems that ros2 is behind ros2-jazzy.

And I fixed that. There were some features not properly backported. But in the future, please make all PRs against ros2.

ct2034 added a commit that referenced this issue Jul 30, 2024
Without this, downstream packages have missing symbols

Relates to: #387

(cherry picked from commit d8fef69)

Co-authored-by: Ramon Wijnands <[email protected]>
@Rayman
Copy link
Contributor

Rayman commented Jul 30, 2024

If you have any more build failure, feel free to ping me

@ct2034
Copy link
Collaborator

ct2034 commented Jul 31, 2024

see ros/rosdistro#42285 for the release

@ct2034 ct2034 closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants